tree c96b84b73505bc4318dbf2e30b8dd445204eb731
parent 257a3d76342f3ac387258ff0eb4bcc5dae26e2db
author Tom Sepez <tsepez@chromium.org> 1667432200 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1667432200 +0000

Actually fix clang-tidy report

Returning a retained reference is always safer, although this
is not reachable in practice. The clang-tidy report fires when
a function returning a retained reference is assigned to a bare
pointer because it can't deduce that there are other references.
When the temporary holding the retained result prior to conversion
goes out of scope at the next semicolon, the pointer outlives it.

Fixed: chromium:1380478
Change-Id: Iaa582b40c2f6a8d4fb227a2437e4a1635c618521
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100612
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>