tree 2c95b7f909c7da456cb849f6d9c926d5584a7708
parent edcc78d9c625b27ea8654368d5ff56759f968814
author Tom Sepez <tsepez@chromium.org> 1622850261 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1622850261 +0000

[code health] Prefer Optional<>::has_value() to implicit operator bool()

Per offline discussion, this improves readability when the underlying
type T is convertible to bool itself. Do so consistently for all types,
but stop short of removing operator bool() from PDFium's copy of
third_party/base/optional.h since several gtest macros depend on its
presence.

-- Remove some `auto` and/or spell out full return type.

Change-Id: Id9a9788e2357d99f0ae7ca53b3b66808c70ac754
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/81350
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>