)]}' { "commit": "e7279b524104c51800f5c21439e3bd9102356b76", "tree": "934c897248305107416cae9e1be69a614757ec16", "parents": [ "447754b47382a16bbb033a8ef69c7931649cfc83" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Mar 19 22:47:29 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 19 22:47:29 2019 +0000" }, "message": "CFX_SeekableStreamProxy should not be an IFX_SeekableStream.\n\nAlthough it implements methods with similar sounding names, the size\nparameters in CFX_SeekableStreamProxy are in terms of wchar_t, not\nbytes. Callers through the virtual interface might get confused (but\ncurrently there isn\u0027t any such bad usage).\n\n- Remove unused method.\n- Make one other method private.\n- Make enum From private.\n\nChange-Id: Ifa798f33d4c40ea88d358f340c6f7f4b70655f40\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52091\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "c0317ca521923ed5c92f1e8994868c50d9095390", "old_mode": 33188, "old_path": "core/fxcrt/cfx_seekablestreamproxy.cpp", "new_id": "d01e1d18fe8484e1268d7617097e47cbaf31453d", "new_mode": 33188, "new_path": "core/fxcrt/cfx_seekablestreamproxy.cpp" }, { "type": "modify", "old_id": "70aff0ac9d7a113224da0146ed913aded3ffa3ed", "old_mode": 33188, "old_path": "core/fxcrt/cfx_seekablestreamproxy.h", "new_id": "d6ea160af74632184583f4d6dd0b0181492c8a7a", "new_mode": 33188, "new_path": "core/fxcrt/cfx_seekablestreamproxy.h" }, { "type": "modify", "old_id": "3d7cc7882939831415bb05cdc0f32d84b0316451", "old_mode": 33188, "old_path": "core/fxcrt/xml/cfx_xmlparser.h", "new_id": "38866c88b700262cbea1036aff810c882a37e319", "new_mode": 33188, "new_path": "core/fxcrt/xml/cfx_xmlparser.h" } ] }