tree 12f7c8a78695c84eeea1d483b4703e67ea728838
parent 86e61dfb3137169bf269948a308007c8320c38bd
author Lei Zhang <thestig@chromium.org> 1561151938 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1561151938 +0000

Change PNG functions to return std::vector.

Currently, PNG functions pass the std::vector containing the data an an
out parameters, with a separate bool return value to indicate success or
failure. Instead of doing this, just return the std::vector and check
whether it contains data or not.

For affected functions that return std::vector, use the same variable in
all return paths to make it obvious to the compiler that it can apply
RVO and not create a copy.

Change-Id: Ia1f84a6be29fe2d86df800607a258747999b311f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/56653
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>