)]}'
{
  "commit": "eb9502ffdfb27e61ea587cbfbb03092ded2b5630",
  "tree": "be1b7ac0e6918be8afd3a6476c5ad5c107fdb732",
  "parents": [
    "269963f90fa882869c3a33c8c9ecba41351cb27d"
  ],
  "author": {
    "name": "dsinclair",
    "email": "dsinclair@chromium.org",
    "time": "Mon Apr 09 17:56:15 2018 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Apr 09 17:56:15 2018 +0000"
  },
  "message": "Revert \"Remove CXFA nodes instead of CFX_XML nodes\"\n\nThis reverts commit 2b4ad9ff5bf1727d12ef2bcce7e3fa925bbe8978.\n\nReason for revert: Causing crashes on windows:\n\nRendering PDF file E:\\b\\build\\slave\\windows_xfa\\build\\pdfium\\out\\debug_xfa_v8\\gen\\pdfium\\testing\\pixel\\static_list_box_caption.pdf.\n\n\u003d\u003d\u003d\u003d C stack trace \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\ndiff: 0.00% passed\n\tstd::tuple\u003cCXFA_Node * __ptr64 const \u0026 __ptr64\u003e::tuple\u003cCXFA_Node * __ptr64 const \u0026 __ptr64\u003e [0x0000000141785700+48]\n\t??@875fbed02c72fe689afc0ad24a247bf8@ [0x000000013F7BB443+131]\n\t??$_Buynode@AEBUpiecewise_construct_t@std@@V?$tuple@AEBQEAVCXFA_Node@@@2@V?$tuple@$$V@2@@?$_Tree_comp_alloc@V?$_Tmap_traits@PEAVCXFA_Node@@V?$unique_ptr@V?$map@IV?$unique_ptr@U?$pair@V?$set@PEAVCXFA_Node@@U?$less@PEAVCXFA_Node@@@std@@V?$allocator@PEAVCXFA [0x0000000141785309+169]\n\t??@2b14910fe4cc3866ca68e10bfed05253@ [0x000000013F7CCB09+185]\n\tCJX_Object::SetAttributeValue [0x000000013FAE0F7E+302]\n\tv8::internal::compiler::Int64Lowering::LowerNode [0x000000013FBB04C0+31920]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A43A3+9603]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A2048+552]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A3436+5654]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A1FEE+462]\n\tCXFA_Document::DoDataMerge [0x00000001417A5F96+3142]\n\tCXFA_FFDocView::StartLayout [0x00000001416BECCD+93]\n\tCPDFXFA_Context::LoadXFADoc [0x000000014169162D+669]\n\tFPDF_LoadXFA [0x0000000140AC5A2A+42]\n\tstd::_Compressed_pair\u003cstd::default_delete\u003cCFWL_WidgetProperties\u003e,CFWL_WidgetProperties * __ptr64,1\u003e::_Get_first [0x000000013F72A648+1432]\n\tmain [0x000000013F727C05+1685]\n\tinvoke_main [0x0000000141CDB924+52] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:79)\n\t__scrt_common_main_seh [0x0000000141CDB817+295] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:283)\n\t__scrt_common_main [0x0000000141CDB6DE+14] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:326)\n\tmainCRTStartup [0x0000000141CDB9B9+9] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_main.cpp:17)\n\tBaseThreadInitThunk [0x0000000077415A4D+13]\n\tRtlUserThreadStart [0x000000007764B831+33]\nRendering PDF file E:\\b\\build\\slave\\windows_xfa\\build\\pdfium\\out\\debug_xfa_v8\\gen\\pdfium\\testing\\pixel\\resolve_nodes.pdf.\n\n\u003d\u003d\u003d\u003d C stack trace \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n\tstd::tuple\u003cCXFA_Node * __ptr64 const \u0026 __ptr64\u003e::tuple\u003cCXFA_Node * __ptr64 const \u0026 __ptr64\u003e [0x0000000141785700+48]\n\t??@875fbed02c72fe689afc0ad24a247bf8@ [0x000000013F7BB443+131]\n\t??$_Buynode@AEBUpiecewise_construct_t@std@@V?$tuple@AEBQEAVCXFA_Node@@@2@V?$tuple@$$V@2@@?$_Tree_comp_alloc@V?$_Tmap_traits@PEAVCXFA_Node@@V?$unique_ptr@V?$map@IV?$unique_ptr@U?$pair@V?$set@PEAVCXFA_Node@@U?$less@PEAVCXFA_Node@@@std@@V?$allocator@PEAVCXFA [0x0000000141785309+169]\n\t??@2b14910fe4cc3866ca68e10bfed05253@ [0x000000013F7CCB09+185]\n\tCJX_Object::SetAttributeValue [0x000000013FAE0F7E+302]\n\tv8::internal::compiler::Int64Lowering::LowerNode [0x000000013FBB03F6+31718]\n\tCXFA_Document::DataMerge_UpdateBindingRelations [0x00000001417A48DA+1066]\n\tCXFA_Document::DataMerge_UpdateBindingRelations [0x00000001417A4ED8+2600]\n\tCXFA_Document::DataMerge_UpdateBindingRelations [0x00000001417A4ED8+2600]\n\tCXFA_Document::DataMerge_UpdateBindingRelations [0x00000001417A4ED8+2600]\n\tCXFA_Document::DataMerge_UpdateBindingRelations [0x00000001417A4ED8+2600]\n\tCXFA_Document::DataMerge_UpdateBindingRelations [0x00000001417A4512+98]\n\tCXFA_Document::DoDataMerge [0x00000001417A5FF8+3240]\n\tCXFA_FFDocView::StartLayout [0x00000001416BECCD+93]\n\tCPDFXFA_Context::LoadXFADoc [0x000000014169162D+669]\n\tFPDF_LoadXFA [0x0000000140AC5A2A+42]\n\tstd::_Compressed_pair\u003cstd::default_delete\u003cCFWL_WidgetProperties\u003e,CFWL_WidgetProperties * __ptr64,1\u003e::_Get_first [0x000000013F72A648+1432]\n\tmain [0x000000013F727C05+1685]\n\tinvoke_main [0x0000000141CDB924+52] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:79)\n\t__scrt_common_main_seh [0x0000000141CDB817+295] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:283)\n\t__scrt_common_main [0x0000000141CDB6DE+14] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:326)\n\tmainCRTStartup [0x0000000141CDB9B9+9] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_main.cpp:17)\n\tBaseThreadInitThunk [0x0000000077415A4D+13]\n\tRtlUserThreadStart [0x000000007764B831+33]\nFAILURE: static_list_box_caption.pdf; Command \u0027[\u0027E:\\\\b\\\\build\\\\slave\\\\windows_xfa\\\\build\\\\pdfium\\\\out\\\\debug_xfa_v8\\\\pdfium_test.exe\u0027, \u0027--send-events\u0027, \u0027--png\u0027, \u0027--md5\u0027, \u0027E:\\\\b\\\\build\\\\slave\\\\windows_xfa\\\\build\\\\pdfium\\\\out\\\\debug_xfa_v8\\\\gen\\\\pdfium\\\\testing\\\\pixel\\\\static_list_box_caption.pdf\u0027]\u0027 returned non-zero exit status -1073741819\nRendering PDF file E:\\b\\build\\slave\\windows_xfa\\build\\pdfium\\out\\debug_xfa_v8\\gen\\pdfium\\testing\\pixel\\standard_symbols.pdf.\n\n\u003d\u003d\u003d\u003d C stack trace \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n\tstd::tuple\u003cCXFA_Node * __ptr64 const \u0026 __ptr64\u003e::tuple\u003cCXFA_Node * __ptr64 const \u0026 __ptr64\u003e [0x0000000141785700+48]\nFAILURE: resolve_nodes.pdf; Command \u0027[\u0027E:\\\\b\\\\build\\\\slave\\\\windows_xfa\\\\build\\\\pdfium\\\\out\\\\debug_xfa_v8\\\\pdfium_test.exe\u0027, \u0027--send-events\u0027, \u0027--png\u0027, \u0027--md5\u0027, \u0027E:\\\\b\\\\build\\\\slave\\\\windows_xfa\\\\build\\\\pdfium\\\\out\\\\debug_xfa_v8\\\\gen\\\\pdfium\\\\testing\\\\pixel\\\\resolve_nodes.pdf\u0027]\u0027 returned non-zero exit status -1073741819\n\t??@875fbed02c72fe689afc0ad24a247bf8@ [0x000000013F7BB443+131]\n\t??$_Buynode@AEBUpiecewise_construct_t@std@@V?$tuple@AEBQEAVCXFA_Node@@@2@V?$tuple@$$V@2@@?$_Tree_comp_alloc@V?$_Tmap_traits@PEAVCXFA_Node@@V?$unique_ptr@V?$map@IV?$unique_ptr@U?$pair@V?$set@PEAVCXFA_Node@@U?$less@PEAVCXFA_Node@@@std@@V?$allocator@PEAVCXFA [0x0000000141785309+169]\n\t??@2b14910fe4cc3866ca68e10bfed05253@ [0x000000013F7CCB09+185]\n\tCJX_Object::SetAttributeValue [0x000000013FAE0F7E+302]\n\tv8::internal::compiler::Int64Lowering::LowerNode [0x000000013FBB04C0+31920]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A43A3+9603]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A2048+552]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A3436+5654]\n\tCXFA_Document::DataMerge_CopyContainer [0x00000001417A1FEE+462]\n\tCXFA_Document::DoDataMerge [0x00000001417A5F96+3142]\n\tCXFA_FFDocView::StartLayout [0x00000001416BECCD+93]\n\tCPDFXFA_Context::LoadXFADoc [0x000000014169162D+669]\n\tFPDF_LoadXFA [0x0000000140AC5A2A+42]\n\tstd::_Compressed_pair\u003cstd::default_delete\u003cCFWL_WidgetProperties\u003e,CFWL_WidgetProperties * __ptr64,1\u003e::_Get_first [0x000000013F72A648+1432]\n\tmain [0x000000013F727C05+1685]\n\tinvoke_main [0x0000000141CDB924+52] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:79)\n\t__scrt_common_main_seh [0x0000000141CDB817+295] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:283)\n\t__scrt_common_main [0x0000000141CDB6DE+14] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_common.inl:326)\n\tmainCRTStartup [0x0000000141CDB9B9+9] (f:\\dd\\vctools\\crt\\vcstartup\\src\\startup\\exe_main.cpp:17)\n\tBaseThreadInitThunk [0x0000000077415A4D+13]\n\tRtlUserThreadStart [0x000000007764B831+33]\nFAILURE: standard_symbols.pdf; Command \u0027[\u0027E:\\\\b\\\\build\\\\slave\\\\windows_xfa\\\\build\\\\pdfium\\\\out\\\\debug_xfa_v8\\\\pdfium_test.exe\u0027, \u0027--send-events\u0027, \u0027--png\u0027, \u0027--md5\u0027, \u0027E:\\\\b\\\\build\\\\slave\\\\windows_xfa\\\\build\\\\pdfium\\\\out\\\\debug_xfa_v8\\\\gen\\\\pdfium\\\\testing\\\\pixel\\\\standard_symbols.pdf\u0027]\u0027 returned non-zero exit status -1073741819\n\nOriginal change\u0027s description:\n\u003e Remove CXFA nodes instead of CFX_XML nodes\n\u003e \n\u003e When we set data into the CJX nodes, we need to update the backing store\n\u003e of the XFA nodes, which are the XML nodes. When we update the backing\n\u003e store, there are cases where we need to remove the children (setting\n\u003e CData on a node or setting the value of an Attribute which is backed by\n\u003e a real node).\n\u003e \n\u003e Currently we call DeleteChildren on the XML node. This causes issues\n\u003e when we cleanup the tree as XFA nodes may point to these deleted XML\n\u003e nodes.\n\u003e \n\u003e Instead, this CL cleans up the XFA nodes which will in turn clean up the\n\u003e XML nodes. This seems like the right thing to do as we no longer have\n\u003e the backing nodes, so we should no longer have the XFA nodes on top of\n\u003e them.\n\u003e \n\u003e Bug: chromium:813155\n\u003e Change-Id: I63d53fd56999ec9d3b3af2ab5952b374663f040c\n\u003e Reviewed-on: https://pdfium-review.googlesource.com/29950\n\u003e Reviewed-by: Henrique Nakashima \u003chnakashima@chromium.org\u003e\n\u003e Commit-Queue: dsinclair \u003cdsinclair@chromium.org\u003e\n\nTBR\u003dthestig@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org\n\nChange-Id: Ic6b2fbeb9f8217292da0a722e143d96f9972056a\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: chromium:813155\nReviewed-on: https://pdfium-review.googlesource.com/29974\nReviewed-by: dsinclair \u003cdsinclair@chromium.org\u003e\nCommit-Queue: dsinclair \u003cdsinclair@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "7122d95bffb339505a79828877351784159657f8",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/parser/cxfa_node.cpp",
      "new_id": "3823d2eae02507d438e2020b8986aa8093db605e",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/parser/cxfa_node.cpp"
    }
  ]
}