commit ec100d689d44154a7fff78aa89fe89c8e20dd5b7
author Lei Zhang <thestig@chromium.org> Wed Mar 13 22:45:29 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Mar 13 22:45:29 2019 +0000
tree af4c70ae5bbd41261d7b837df161989847c7fa79
parent 1fe1f39ee3fa56c01256725761765ec111a1973e

Limit the size of 1D barcodes to 8K.

At 8K characters, 1D barcodes are likely > 50 inches in width. This is
likely sufficient for most use cases. Limit the size to stop the barcode
fuzzer from wasting time encoding larger barcodes.

BUG=chromium:939880

Change-Id: I3140e1be4df1715e3f3784bffa436d92b6d352ac
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/51851
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fxbarcode/cbc_codabar.cpp

diff --git a/fxbarcode/cbc_codabar.cpp b/fxbarcode/cbc_codabar.cpp
index 5822cbe..0abfbf4 100644
--- a/fxbarcode/cbc_codabar.cpp
+++ b/fxbarcode/cbc_codabar.cpp
@@ -32,7 +32,7 @@
 CBC_Codabar::~CBC_Codabar() {}
 
 bool CBC_Codabar::Encode(WideStringView contents) {
-  if (contents.IsEmpty())
+  if (contents.IsEmpty() || contents.GetLength() > kMaxInputLengthBytes)
     return false;
 
   BCFORMAT format = BCFORMAT_CODABAR;

fxbarcode/cbc_code128.cpp

diff --git a/fxbarcode/cbc_code128.cpp b/fxbarcode/cbc_code128.cpp
index 712c1f7..a3da7bc 100644
--- a/fxbarcode/cbc_code128.cpp
+++ b/fxbarcode/cbc_code128.cpp
@@ -32,7 +32,7 @@
 CBC_Code128::~CBC_Code128() {}
 
 bool CBC_Code128::Encode(WideStringView contents) {
-  if (contents.IsEmpty())
+  if (contents.IsEmpty() || contents.GetLength() > kMaxInputLengthBytes)
     return false;
 
   BCFORMAT format = BCFORMAT_CODE_128;

fxbarcode/cbc_code39.cpp

diff --git a/fxbarcode/cbc_code39.cpp b/fxbarcode/cbc_code39.cpp
index 63a3c56..d9dc106 100644
--- a/fxbarcode/cbc_code39.cpp
+++ b/fxbarcode/cbc_code39.cpp
@@ -32,7 +32,7 @@
 CBC_Code39::~CBC_Code39() {}
 
 bool CBC_Code39::Encode(WideStringView contents) {
-  if (contents.IsEmpty())
+  if (contents.IsEmpty() || contents.GetLength() > kMaxInputLengthBytes)
     return false;
 
   BCFORMAT format = BCFORMAT_CODE_39;

fxbarcode/cbc_eancode.cpp

diff --git a/fxbarcode/cbc_eancode.cpp b/fxbarcode/cbc_eancode.cpp
index ffb116e..9de16ae 100644
--- a/fxbarcode/cbc_eancode.cpp
+++ b/fxbarcode/cbc_eancode.cpp
@@ -20,7 +20,7 @@
 }
 
 bool CBC_EANCode::Encode(WideStringView contents) {
-  if (contents.IsEmpty())
+  if (contents.IsEmpty() || contents.GetLength() > kMaxInputLengthBytes)
     return false;
 
   BCFORMAT format = GetFormat();

fxbarcode/cbc_onecode.h

diff --git a/fxbarcode/cbc_onecode.h b/fxbarcode/cbc_onecode.h
index 4470ad8..26aa943 100644
--- a/fxbarcode/cbc_onecode.h
+++ b/fxbarcode/cbc_onecode.h
@@ -18,6 +18,10 @@
 
 class CBC_OneCode : public CBC_CodeBase {
  public:
+  // Limit the size of 1D barcodes. Typical 1D barcodes are short so this should
+  // be sufficient for most use cases.
+  static constexpr size_t kMaxInputLengthBytes = 8192;
+
   explicit CBC_OneCode(std::unique_ptr<CBC_Writer> pWriter);
   ~CBC_OneCode() override;