tree 1ac519ddabd3994d25ef6db239cbfabea7f11365
parent 1268b5943b4d08ed06dbe1a91ee45f3f522991a5
author Tom Sepez <tsepez@chromium.org> 1552516811 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1552516811 +0000

Revert "Replace some in/out parameters in cfgas_stringformatter.cpp"

This reverts commit 1268b5943b4d08ed06dbe1a91ee45f3f522991a5.

Reason for revert: Adding state to formatter may be cleaner than passing arguments

Original change's description:
> Replace some in/out parameters in cfgas_stringformatter.cpp
> 
> Doing so allows the optimizer to remove another bounds check
> in GetLiteralText() since there is less aliasing possible.
> 
> - small logic tidy in FormatDateTime()
> - consolidate FormatNull() and FormatZero() implementations.
> 
> Change-Id: If7b2e7acc1b01ccb64792510a64286016c623ad0
> Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/51850
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>

TBR=thestig@chromium.org,tsepez@chromium.org

Change-Id: I3782a469b3e4273c280c6a441d1f096c0ba8ee12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/51870
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>