)]}'
{
  "commit": "eec3a366adbfada36b98f1de651546ee09df8fc0",
  "tree": "794aa8c69392b60d8737a8a5b424732b98bdd4b4",
  "parents": [
    "4ce94e118d66064715de5baebeb4b2b580dcac66"
  ],
  "author": {
    "name": "weili",
    "email": "weili@chromium.org",
    "time": "Sat Jun 18 06:25:37 2016 -0700"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Sat Jun 18 06:25:37 2016 -0700"
  },
  "message": "Make code compile with clang_use_chrome_plugin (final)\n\nThis change mainly contains files in xfa/ and fxjse/ directories\nwhich were not covered by previous changes.\nThis is part of the efforts to make PDFium code compilable\nby Clang chromium style plugins. After this change, PDFium can be\ncompiled with \"clang_use_chrome_plugin\u003dtrue\" for GN build. Since\nclang_use_chrome_plugin is true by default, we no longer need to\nset this parameter explicitly.\n\nThe changes are mainly the following:\n-- move inline constructor/destructor of complex class/struct out-of-line;\n-- add constructor/destructor of complex class/struct if not\n explicitly defined;\n-- add explicit out-of-line copy constructor when needed;\n-- move inline virtual functions out-of-line;\n-- Properly mark virtual functions with \u0027override\u0027;\n-- some minor cleanups;\n\nBUG\u003dpdfium:469\n\nReview-Url: https://codereview.chromium.org/2072803002\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e010ace1d462a3062fc2e9a0f2f0ec9ebe36c658",
      "old_mode": 33188,
      "old_path": "BUILD.gn",
      "new_id": "7930c7c67b3c127f2f82cb26d5f2b1a9cd3fedf1",
      "new_mode": 33188,
      "new_path": "BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "bb133fba5867b76ff51e0c2e6eec952970bfa620",
      "old_mode": 33188,
      "old_path": "fxjse/class.cpp",
      "new_id": "1dba7f073fd370c9eae7b0298486c3b3fe70b341",
      "new_mode": 33188,
      "new_path": "fxjse/class.cpp"
    },
    {
      "type": "modify",
      "old_id": "bb1db6d48cef65b87afb39d5954a698403e2d611",
      "old_mode": 33188,
      "old_path": "fxjse/include/cfxjse_class.h",
      "new_id": "b4953d21d318417daf3686edf90aefc9816827ba",
      "new_mode": 33188,
      "new_path": "fxjse/include/cfxjse_class.h"
    },
    {
      "type": "modify",
      "old_id": "74b4bab2e2aa39a3d1c273955d9d2bd59b773a64",
      "old_mode": 33188,
      "old_path": "fxjse/include/cfxjse_value.h",
      "new_id": "6e14d48f8fdbacc7a9d6fb34cbc8626bf51cec99",
      "new_mode": 33188,
      "new_path": "fxjse/include/cfxjse_value.h"
    },
    {
      "type": "modify",
      "old_id": "bf171eef7e30a4e278d0c31889ba42720194b085",
      "old_mode": 33188,
      "old_path": "fxjse/runtime.cpp",
      "new_id": "29814bdc7e79c92e51d0ec7ff1e337a0999e11cb",
      "new_mode": 33188,
      "new_path": "fxjse/runtime.cpp"
    },
    {
      "type": "modify",
      "old_id": "e3b4113a50c0bc1ec051d37ae63df3445962c41c",
      "old_mode": 33188,
      "old_path": "fxjse/runtime.h",
      "new_id": "ff3be3a5210945a84a14104d2d3f10c748bd18a5",
      "new_mode": 33188,
      "new_path": "fxjse/runtime.h"
    },
    {
      "type": "modify",
      "old_id": "743169dd7b38984326bbd0e54281c403ad73d7ff",
      "old_mode": 33188,
      "old_path": "fxjse/value.cpp",
      "new_id": "aba640210a268769e518de7a859a585a81f36a1f",
      "new_mode": 33188,
      "new_path": "fxjse/value.cpp"
    },
    {
      "type": "modify",
      "old_id": "da0492bf853b236de8ac83786af6428243b8889e",
      "old_mode": 33188,
      "old_path": "xfa.gyp",
      "new_id": "7cf0cf7051b7d56efbc0a317cd607c8252fafba2",
      "new_mode": 33188,
      "new_path": "xfa.gyp"
    },
    {
      "type": "modify",
      "old_id": "11a6d5c3f7b57e6e2d84504de9e62e45640b5998",
      "old_mode": 33188,
      "old_path": "xfa/fde/cfde_txtedtengine.cpp",
      "new_id": "8c950f5ab3535dfc84d4b42e1d72094552bbfb3c",
      "new_mode": 33188,
      "new_path": "xfa/fde/cfde_txtedtengine.cpp"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "053b2774e6207fb8ff79bd8a4476068f55ea88f6",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_css.cpp"
    },
    {
      "type": "modify",
      "old_id": "551f8f8962bdff30bf61c2db3798ed9165bb0938",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_css.h",
      "new_id": "a0ede3d9f7b2c71210f9c63e273964188d7718a1",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_css.h"
    },
    {
      "type": "modify",
      "old_id": "76a893d2d10b279bfdb23acc7fe510c6ca483ebe",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_csscache.cpp",
      "new_id": "a355a43c61c63b93221f109df9d9db4fb07d157f",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_csscache.cpp"
    },
    {
      "type": "modify",
      "old_id": "28962e45ebc6e09274032d635142496c13f06344",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_csscache.h",
      "new_id": "bab86ea88042b2b0d88525db6ed7e748a526d678",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_csscache.h"
    },
    {
      "type": "modify",
      "old_id": "ac8c4669323ede9c6e6370390162779f57c2fd74",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssdatatable.cpp",
      "new_id": "c2767e7eb2d95b672accada48afa1947c1f26f3b",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssdatatable.cpp"
    },
    {
      "type": "modify",
      "old_id": "d61ff09ae7c99bdecd6e5b073d56424475b28140",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssdatatable.h",
      "new_id": "252efdce5037061e94a8f80b84030f3f91a67b2d",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssdatatable.h"
    },
    {
      "type": "modify",
      "old_id": "007657d154b88fb3a99ee40a56390f33f928dafd",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssstyleselector.cpp",
      "new_id": "6082136fe03a4732d598d5da0487654c5f05accf",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssstyleselector.cpp"
    },
    {
      "type": "modify",
      "old_id": "3af75a7b9e43ae7e318fe7fa160c30938f760847",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssstyleselector.h",
      "new_id": "042e98924226db666f79b7306509a4d52c3cd9ad",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssstyleselector.h"
    },
    {
      "type": "modify",
      "old_id": "6708ca2e72776f06864c47495dc07c5eb4428d4f",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssstylesheet.cpp",
      "new_id": "f0b071223f3bb118ca5f5ab0882aafd4bfd0e811",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssstylesheet.cpp"
    },
    {
      "type": "modify",
      "old_id": "4c5157966161e33e0ebe8f1cc319377514299062",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_cssstylesheet.h",
      "new_id": "83eac993e710193fbbb4309b843910c54d5a2d53",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_cssstylesheet.h"
    },
    {
      "type": "modify",
      "old_id": "a4e9249055442813dcb5a1825648cd15da54347d",
      "old_mode": 33188,
      "old_path": "xfa/fde/css/fde_csssyntax.h",
      "new_id": "294dfcb54002306236dc6674e73e2075fe4c528e",
      "new_mode": 33188,
      "new_path": "xfa/fde/css/fde_csssyntax.h"
    },
    {
      "type": "modify",
      "old_id": "7df5de2638545ae5c83d53f0d1f7591132ff4ae3",
      "old_mode": 33188,
      "old_path": "xfa/fde/fde_object.h",
      "new_id": "2af18ec3b7a42db738c517d3478b250ab878e4b8",
      "new_mode": 33188,
      "new_path": "xfa/fde/fde_object.h"
    },
    {
      "type": "modify",
      "old_id": "8ecf46e5c84e40b8669322479091d951f94e3b8f",
      "old_mode": 33188,
      "old_path": "xfa/fde/ifde_txtedtengine.h",
      "new_id": "cf760035cf7ede8176ac5ae66c7d4de39bc3a44f",
      "new_mode": 33188,
      "new_path": "xfa/fde/ifde_txtedtengine.h"
    },
    {
      "type": "modify",
      "old_id": "4959f2bc6990266feacb56e83261e3b75470f8e7",
      "old_mode": 33188,
      "old_path": "xfa/fde/tto/fde_textout.h",
      "new_id": "14ca5e19bb728cfe7f1294a928bbd2f634270f1f",
      "new_mode": 33188,
      "new_path": "xfa/fde/tto/fde_textout.h"
    },
    {
      "type": "modify",
      "old_id": "b71d8b8f4fd87e6e035682e8e039cbdd9eefef18",
      "old_mode": 33188,
      "old_path": "xfa/fde/xml/fde_xml_imp.cpp",
      "new_id": "da7e0a2fca30baac49b5f0c03334d9326d6874fb",
      "new_mode": 33188,
      "new_path": "xfa/fde/xml/fde_xml_imp.cpp"
    },
    {
      "type": "modify",
      "old_id": "b977d693d8d3ce9db5c7cc6651c7f499eb8d9453",
      "old_mode": 33188,
      "old_path": "xfa/fde/xml/fde_xml_imp.h",
      "new_id": "ba75f6b4096a6fa9408047e415ace63a0d9f8bec",
      "new_mode": 33188,
      "new_path": "xfa/fde/xml/fde_xml_imp.h"
    },
    {
      "type": "modify",
      "old_id": "59eb99bcf0bf24a487def64b14504b6e1e8e4dc1",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/fgas_stream.cpp",
      "new_id": "458cf5edada32097303f31506b7bf3ab8f13a73f",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/fgas_stream.cpp"
    },
    {
      "type": "modify",
      "old_id": "4f15fc48452f15cd9f4bc9ec15eddfcde0a3c703",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/fgas_utils.cpp",
      "new_id": "6db7aa35ab85d8b67a42ff2eb623b88dfdbb6a0b",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/fgas_utils.cpp"
    },
    {
      "type": "modify",
      "old_id": "6fef23d96849e515bc4668401b8b747c0bf41c1d",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/fgas_utils.h",
      "new_id": "f01d115b3e00f394c773f3632f6514b668beb733",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/fgas_utils.h"
    },
    {
      "type": "modify",
      "old_id": "c6c1b19ef7e141626596f3ad26cd853f97148356",
      "old_mode": 33188,
      "old_path": "xfa/fgas/font/fgas_stdfontmgr.cpp",
      "new_id": "fc839e9209e6c105483db9c9f9a4bc61c30505a9",
      "new_mode": 33188,
      "new_path": "xfa/fgas/font/fgas_stdfontmgr.cpp"
    },
    {
      "type": "modify",
      "old_id": "b20c942a36dee17d7b6d47efae1a2262e5f10803",
      "old_mode": 33188,
      "old_path": "xfa/fgas/font/fgas_stdfontmgr.h",
      "new_id": "11d91fc7f5e99ae3b51e64d1d5854552e6350bd2",
      "new_mode": 33188,
      "new_path": "xfa/fgas/font/fgas_stdfontmgr.h"
    },
    {
      "type": "modify",
      "old_id": "eed37df35df0d706b7b3086d150728e8bbc40588",
      "old_mode": 33188,
      "old_path": "xfa/fgas/layout/fgas_rtfbreak.cpp",
      "new_id": "848f7f4e938172fbe98eadf4656a33fcf937451c",
      "new_mode": 33188,
      "new_path": "xfa/fgas/layout/fgas_rtfbreak.cpp"
    },
    {
      "type": "modify",
      "old_id": "83d83a6c4539561d0aff0b54d64ea843c3c12f2c",
      "old_mode": 33188,
      "old_path": "xfa/fgas/layout/fgas_rtfbreak.h",
      "new_id": "993dc50f979e9de5d9e102819b105e2f8203ef9c",
      "new_mode": 33188,
      "new_path": "xfa/fgas/layout/fgas_rtfbreak.h"
    },
    {
      "type": "modify",
      "old_id": "c8d33baa80fa4649ed3918d1a4870827ae7bffea",
      "old_mode": 33188,
      "old_path": "xfa/fgas/layout/fgas_textbreak.cpp",
      "new_id": "8eebbed76a0d37d87ab3dcb49d83ca66cafdd90e",
      "new_mode": 33188,
      "new_path": "xfa/fgas/layout/fgas_textbreak.cpp"
    },
    {
      "type": "modify",
      "old_id": "94fa79f5a6b7a7ab8e5dd28c7dfe7eb90904e87d",
      "old_mode": 33188,
      "old_path": "xfa/fgas/layout/fgas_textbreak.h",
      "new_id": "020fa1a3d3bc4151bb434af399f2f7bc9a7598e4",
      "new_mode": 33188,
      "new_path": "xfa/fgas/layout/fgas_textbreak.h"
    },
    {
      "type": "modify",
      "old_id": "7776f5ef3d0d08ef1838e83f6924ae46986c87fb",
      "old_mode": 33188,
      "old_path": "xfa/fxgraphics/cfx_graphics.cpp",
      "new_id": "c3f5b7b09670616ff8a59110987e69de7aecdfa7",
      "new_mode": 33188,
      "new_path": "xfa/fxgraphics/cfx_graphics.cpp"
    },
    {
      "type": "modify",
      "old_id": "3f969432eaaaa3791baeed21e8c1039e49a65356",
      "old_mode": 33188,
      "old_path": "xfa/fxgraphics/include/cfx_graphics.h",
      "new_id": "1c2cb354cc25509ee15a8bac65c2f8c3a54cbc9c",
      "new_mode": 33188,
      "new_path": "xfa/fxgraphics/include/cfx_graphics.h"
    }
  ]
}