tree 6e2db94a671bd5764031c140ee497a6d0670e3ec
parent 8496d13f2daade3d96291c19a0fcfc408fcd128d
author Tom Sepez <tsepez@chromium.org> 1625785945 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1625785945 +0000

De-virtualize IFX_WriteStream::WriteString()

Given a virtual WriteBlock() method, there's no need to have N
identical virtual implementations of WriteString(). Similarly, move
the other write methods from IFX_ArchiveStream to here, and
de-virtualize.

This requires a change to StringWriteStream, which was never actually
seekable, to subclass IFX_RetainableWriteStream, to avoid being called
with a non-zero offset via the consolidated IFX_SeekableWriteStream
method.

In turn, this required changing the arguments to some functions to
be retainable write streams (just as well since they were never
seeked).

Change-Id: I65eb32649b812f6e931635bcecfc4885339446ac
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/82971
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>