tree b59d6f8a9b446b021a59f32adce8cc24999ff128
parent e28f2bdfd9dbf95333929763031cef94b13a4fc5
author Lei Zhang <thestig@chromium.org> 1550084955 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1550084955 +0000

Reuse existing CPDF_InteractiveForm in two APIs.

In FPDFPage_HasFormFieldAtPoint(), the implementation creates a new
CPDF_InteractiveForm object and then examine its form controls.
Constructing CPDF_InteractiveForm objects can be expensive, since
interactive form fields can have hierarchies and inheritance. Meanwhile,
there is a FPDF_FORMHANDLE being passed in and its almost unused. Put it
to use by getting the CPDFSDK_InteractiveForm from the handle. The
CPDFSDK_InteractiveForm then has a pointer to an existing
CPDF_InteractiveForm. Use that instead.

FPDFPage_FormFieldZOrderAtPoint() started out as a sibling of
FPDFPage_HasFormFieldAtPoint(), and has a similar issue.

Change-Id: Ic8928a7354e5fcd8c260d8f4ac824fbc66a18dbe
Reviewed-on: https://pdfium-review.googlesource.com/c/50710
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>