)]}' { "commit": "fc790866bf26d977b2ea3a0c3938bb52895309ea", "tree": "45d3ff29c550ca416abce874e25745a387678d4a", "parents": [ "c01585b18e5b7492a5ecfc9b179af023a560455e" ], "author": { "name": "Tom Sepez", "email": "tsepez@google.com", "time": "Mon Jun 29 14:21:27 2026 -0700" }, "committer": { "name": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com", "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jun 29 14:21:27 2026 -0700" }, "message": "Consolidate CFX_RenderDevice and remove CPDF_WindowsRenderDevice\n\nIntroduce a way to register PostScript encoders globally in\nCFX_GEModule. This technique is needed to preserve layering with\nfxcodec/ strictly above fxge/.\n\nCFX_RenderDevice now retrieves the registered encoders from\nCFX_GEModule internally on Windows instead of requiring them to be\npassed via constructor.\n\nFPDF_InitLibraryWithConfig registers the encoders during library\ninitialization on Windows.\n\nThe final result is that this allows removing CPDF_WindowsRenderDevice\nand makes the core/fpdfapi/render layer platform-agnostic.\n\nCFX_DefaultRenderDevice is removed as well, folding it into\nCFX_RenderDevice.\n\nThe original hierarchy suffered from abstraction inversion: it used\ndeep class inheritance at the frontend (CFX_...RenderDevice) when\nthe actual polymorphism was already happening at the backend\n(RenderDeviceDriverIface).\n\nBy flattening the frontend wrapper to a single concrete, final\nclass, it matches the actual shape of the engine: One rendering\ncontext, multiple pluggable backend drivers.\n\nTests are consolidated by merging the default and Windows device\nunit tests into cfx_renderdevice_unittest.cpp.\n\nTAG\u003dagy\nCONV\u003d95a2f3dd-7384-4cff-9247-9f9d201c4a25\n\nChange-Id: I5d5469bdee4e54bd22e86ab17e4787220627a59c\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/150892\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "5cbf93f2b20b001a7d3255776a37420d0e7c018b", "old_mode": 33188, "old_path": "core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp", "new_id": "3dfc2aec87dbef8a9f1280df83b95272a64a8fd7", "new_mode": 33188, "new_path": "core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp" }, { "type": "modify", "old_id": "65186eafadd521062f66699544e6728a7a8600a2", "old_mode": 33188, "old_path": "core/fpdfapi/render/BUILD.gn", "new_id": "7619843201a8b8a300c6b70f35fc8feb67d973ea", "new_mode": 33188, "new_path": "core/fpdfapi/render/BUILD.gn" }, { "type": "modify", "old_id": "163fad30ff539dd36eb9e48de207890df67dcb78", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_devicebuffer.cpp", "new_id": "a0b9a64fd2143021742f0c7df5b9b6a773309284", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_devicebuffer.cpp" }, { "type": "modify", "old_id": "794d57936c35c33aac1b1bf785be66eb6de9c498", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_imagerenderer.cpp", "new_id": "cd9f6488dfd306b2ac59f704b38cc51e7c783467", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_imagerenderer.cpp" }, { "type": "modify", "old_id": "653aa24fba6b88a12d15544ebb82ed3d227a054b", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_imagerenderer.h", "new_id": "b15e514fd82cc4d1e5a3f1772a052e0c75d1f2c7", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_imagerenderer.h" }, { "type": "modify", "old_id": "c699c1184fa70349f451c1587e97747f824ff15b", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_rendercontext.cpp", "new_id": "05e41ac5cf33b16233f9ac9e1e6dc0d176488029", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_rendercontext.cpp" }, { "type": "modify", "old_id": "2fd9a5c9949294114d70432c24b7c0b4e3026756", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_rendershading.cpp", "new_id": "45e66bc04fe19de7d50d329376b2da588d277575", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_rendershading.cpp" }, { "type": "modify", "old_id": "3fb69b636df8dffd44d7306905578d424dafd528", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_renderstatus.cpp", "new_id": "f46c193a9e3165249058a9e93fbc15d74209da4d", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_renderstatus.cpp" }, { "type": "modify", "old_id": "81237bd804ecf3320d694ddc89075a8ea13d32a3", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_rendertiling.cpp", "new_id": "2f2e7b44997b13dab28078d3fe9f0470b5a4f800", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_rendertiling.cpp" }, { "type": "modify", "old_id": "30ab68af8e2ffeb11699c08a9de3baa4110b2526", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp", "new_id": "5a4c4f5b66f9a222934feed606f8a572e2105a15", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp" }, { "type": "modify", "old_id": "fa80747af9c27f0c764db9576b8c7b63fa071952", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_scaledrenderbuffer.h", "new_id": "34e848c629bf5370d1d37d01f77ea9ce59b52f3d", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_scaledrenderbuffer.h" }, { "type": "delete", "old_id": "e3e55640dbbe5bc9312a7719872d40023d8ff0be", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_windowsrenderdevice.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "c83c588fd0bfff7dcb72daea887af09e704e9842", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_windowsrenderdevice.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "12a1db25df54f99f033ad2b99e01575162c686b0", "old_mode": 33188, "old_path": "core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp", "new_id": "994ba8066ca010ea08ea3d1c648b75d7bb5de7de", "new_mode": 33188, "new_path": "core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp" }, { "type": "modify", "old_id": "25d2b5327d9e0f7933bbc2674881a06aa6dca66d", "old_mode": 33188, "old_path": "core/fxge/BUILD.gn", "new_id": "d54dbab5216a0bfeee3598b92f0baec91fa46e9b", "new_mode": 33188, "new_path": "core/fxge/BUILD.gn" }, { "type": "modify", "old_id": "3c78cd91675e9e25524ee8236c496f9e4591d205", "old_mode": 33188, "old_path": "core/fxge/agg/cfx_agg_devicedriver.cpp", "new_id": "24351a51ad16f01af342d3eeb7fda64cdc9db244", "new_mode": 33188, "new_path": "core/fxge/agg/cfx_agg_devicedriver.cpp" }, { "type": "modify", "old_id": "3adfbda73852eec1a7a668a6d5e4d0418fe8eb6d", "old_mode": 33188, "old_path": "core/fxge/agg/cfx_agg_devicedriver.h", "new_id": "25256ba8993512106f45060ac25dd9680d113378", "new_mode": 33188, "new_path": "core/fxge/agg/cfx_agg_devicedriver.h" }, { "type": "delete", "old_id": "0dd6ad5b90f4efe48fdc5f1d5c13d0bc47f679bb", "old_mode": 33188, "old_path": "core/fxge/cfx_defaultrenderdevice.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "6e798f6a70e7d016ebaaed1d0bb940e6643cca3a", "old_mode": 33188, "old_path": "core/fxge/cfx_defaultrenderdevice.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "c2a1369407b2ac6eef748ba518692a6b3050412e", "old_mode": 33188, "old_path": "core/fxge/cfx_defaultrenderdevice_unittest.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "64aa31b9f68448cd0d90d0d3fd02b65d04dd7254", "old_mode": 33188, "old_path": "core/fxge/cfx_renderdevice.cpp", "new_id": "8c6e2a760cefa83adc284b9a748dd3dd23bbe4d6", "new_mode": 33188, "new_path": "core/fxge/cfx_renderdevice.cpp" }, { "type": "modify", "old_id": "9d131120af3fbf2dee34fdd0e12200c94083c59c", "old_mode": 33188, "old_path": "core/fxge/cfx_renderdevice.h", "new_id": "a7afb69a72f2f85ddcf5bcf6a74f73644338be40", "new_mode": 33188, "new_path": "core/fxge/cfx_renderdevice.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "d546f583d01b1a5c20d9365e776f7ca0da4e05a9", "new_mode": 33188, "new_path": "core/fxge/cfx_renderdevice_unittest.cpp" }, { "type": "delete", "old_id": "0092a68668bebd9467f5a660b7724ec320d346a2", "old_mode": 33188, "old_path": "core/fxge/cfx_windowsrenderdevice.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "bacc69071df34e9387a1cfc5d87cd7bb19b4fdac", "old_mode": 33188, "old_path": "core/fxge/cfx_windowsrenderdevice.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "c26d9691f670a5424ec544f1f62d95f9fc18f6df", "old_mode": 33188, "old_path": "core/fxge/cfx_windowsrenderdevice_embeddertest.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "e82ee93f797679a17127e3c7741425d03b48327f", "old_mode": 33188, "old_path": "core/fxge/renderdevicedriver_iface.h", "new_id": "56aa736a7ee76ae5e1ed6a6524acbc948d2747fb", "new_mode": 33188, "new_path": "core/fxge/renderdevicedriver_iface.h" }, { "type": "modify", "old_id": "12a7d7df3e92661fc5496aa60a97679835c8688b", "old_mode": 33188, "old_path": "core/fxge/skia/fx_skia_device.cpp", "new_id": "9916f808e1b3547773213c0046a5c0332ede4e15", "new_mode": 33188, "new_path": "core/fxge/skia/fx_skia_device.cpp" }, { "type": "modify", "old_id": "392d1a2e5832f5919addeb66dd6addb1b77bab32", "old_mode": 33188, "old_path": "core/fxge/skia/fx_skia_device.h", "new_id": "193a912ecc1926d548d164a855f0e720d240060b", "new_mode": 33188, "new_path": "core/fxge/skia/fx_skia_device.h" }, { "type": "modify", "old_id": "ba240bed11c1e44f7ec2dd60628711553c7f03af", "old_mode": 33188, "old_path": "core/fxge/skia/fx_skia_device_embeddertest.cpp", "new_id": "17eed8539b3c75080e7fde41eb8ebcdb315b8e1a", "new_mode": 33188, "new_path": "core/fxge/skia/fx_skia_device_embeddertest.cpp" }, { "type": "modify", "old_id": "6305872bfe4803d2063fd5f9a9dddc6f3b69bb80", "old_mode": 33188, "old_path": "core/fxge/win32/cgdi_device_driver.cpp", "new_id": "2f950d579b5debbec4c1285e02a05925539845c8", "new_mode": 33188, "new_path": "core/fxge/win32/cgdi_device_driver.cpp" }, { "type": "modify", "old_id": "dad556907c5e69a1e17e7191ce6994cd0a7cc9e8", "old_mode": 33188, "old_path": "core/fxge/win32/cgdi_device_driver.h", "new_id": "e350333ceb81524dc4c28f7192be91527263f46a", "new_mode": 33188, "new_path": "core/fxge/win32/cgdi_device_driver.h" }, { "type": "modify", "old_id": "eb7c5b837370125c91e76fe78f2b618b40c133fa", "old_mode": 33188, "old_path": "core/fxge/win32/cgdi_printer_driver.cpp", "new_id": "2020eeb4b3621d5ff9bae4a9fcc963cffe34019f", "new_mode": 33188, "new_path": "core/fxge/win32/cgdi_printer_driver.cpp" }, { "type": "modify", "old_id": "6fddc31789edbbb575f9e53b8c18b7f46e58a173", "old_mode": 33188, "old_path": "core/fxge/win32/cps_printer_driver.cpp", "new_id": "cb83206349268a247f4c98138919cbbdb3ff401d", "new_mode": 33188, "new_path": "core/fxge/win32/cps_printer_driver.cpp" }, { "type": "modify", "old_id": "9ed3941f6340af9799169a6f49bdc3833020f4c8", "old_mode": 33188, "old_path": "core/fxge/win32/cps_printer_driver.h", "new_id": "85fbfb56fbc0cbed90f74b045c53b66f670ea9f1", "new_mode": 33188, "new_path": "core/fxge/win32/cps_printer_driver.h" }, { "type": "modify", "old_id": "99af6d79b735eceadb96c49fe923d92b13d4a564", "old_mode": 33188, "old_path": "core/fxge/win32/ctext_only_printer_driver.cpp", "new_id": "957a46e7b08f9f68f54b187701220a9bf47d6f89", "new_mode": 33188, "new_path": "core/fxge/win32/ctext_only_printer_driver.cpp" }, { "type": "modify", "old_id": "559025b3257f166f6ceb93a82ed5740484b29cbf", "old_mode": 33188, "old_path": "core/fxge/win32/ctext_only_printer_driver.h", "new_id": "5b7038f724386e110b96da32d5e2f15b16de43d6", "new_mode": 33188, "new_path": "core/fxge/win32/ctext_only_printer_driver.h" }, { "type": "modify", "old_id": "d23c3e35f504ef79bd6216304056a554998fc7f3", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_annot_embeddertest.cpp", "new_id": "d5526566a44a0f742a06d7a0692e28e994a8d1e3", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_annot_embeddertest.cpp" }, { "type": "modify", "old_id": "5301cf9edfaf57d6de72a11a4878805324277fbf", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_doc_embeddertest.cpp", "new_id": "12799e3ea094c8c97202233e61a83d31a0d69888", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_doc_embeddertest.cpp" }, { "type": "modify", "old_id": "bbe9ad4dbe38ab52307b39a89af818cf7a0ad3ed", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_edit_embeddertest.cpp", "new_id": "15a09d0a4f616e49581021ebb32f31f3d838ee5e", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_edit_embeddertest.cpp" }, { "type": "modify", "old_id": "69373f239235855041b6f97445f4da84a27e5c6c", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_editimg.cpp", "new_id": "32a32126dc334f4f2133d295a1f3065ed15e8187", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_editimg.cpp" }, { "type": "modify", "old_id": "60ae3968fdc61430fa027a227ab7b5162904b5b8", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_editpage_embeddertest.cpp", "new_id": "c4cf9088efff172d168ce74c0057900f21f97ece", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_editpage_embeddertest.cpp" }, { "type": "modify", "old_id": "7a75105382b1aef6d781d2c7390489b7013c934e", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_editpath_embeddertest.cpp", "new_id": "2d480643632f971cdb001080b5061582f47093a7", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_editpath_embeddertest.cpp" }, { "type": "modify", "old_id": "758ef4a99491a9f3e96d29e75df6b3b22c893f56", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_edittext.cpp", "new_id": "5f5ac680bfe1ddcd7ca79dd5d57a4ae438ca8c4f", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_edittext.cpp" }, { "type": "modify", "old_id": "244015df795dbad79eafe6767e054092d3f9c489", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_flatten_embeddertest.cpp", "new_id": "5c54f14234d4950a6e20e695cfdee9e48b2fc433", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_flatten_embeddertest.cpp" }, { "type": "modify", "old_id": "0f2d539eb65260f0ae28ee90dd93354dfdea4d62", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_formfill.cpp", "new_id": "b0ded9bb78e149c76ebb609e8b29d99e746cc8b1", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_formfill.cpp" }, { "type": "modify", "old_id": "344b3cff8bfefd61ca2403bd779e4847e1d19888", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp", "new_id": "64b8af57940a865d4607a080e2d38e1c1a0403be", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp" }, { "type": "modify", "old_id": "fc32b27a6a036b0ac1c49b602c88776ece750f23", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_ppo_embeddertest.cpp", "new_id": "b21e56b471ae65d9439b12ef18a261bebe6aed60", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_ppo_embeddertest.cpp" }, { "type": "modify", "old_id": "33045b75306d8f367b4dc5e31ae8b8a34c39e0b6", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_progressive.cpp", "new_id": "cf211212dafaa4c80d4a5ab7fa098c05a5bd03a3", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_progressive.cpp" }, { "type": "modify", "old_id": "d15ac5f75b93b26b1290f5ff2f2ec90d28ad6657", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_transformpage_embeddertest.cpp", "new_id": "f9a03ead7a0af0b17ecb4ed613f6ed274064fd77", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_transformpage_embeddertest.cpp" }, { "type": "modify", "old_id": "a4dd5720a389fa4af2166f68ea88aca127385e6a", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_view.cpp", "new_id": "dff459cd59fd18f55cea7b94789510dca3ded525", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_view.cpp" }, { "type": "modify", "old_id": "ce69ccb678927cd805722864adaaddbd2eb6ecf0", "old_mode": 33188, "old_path": "fxbarcode/cfx_barcode_unittest.cpp", "new_id": "e06e1f233cfba57808476bdcf2d729f9868d6daa", "new_mode": 33188, "new_path": "fxbarcode/cfx_barcode_unittest.cpp" }, { "type": "modify", "old_id": "cfa3cb85819ccf1c24232567a8a8e4676f5b3f75", "old_mode": 33188, "old_path": "fxbarcode/oned/BC_OneDimWriter.cpp", "new_id": "3b59b1114ff85b5b6b0872c56e603dfb3a614a2a", "new_mode": 33188, "new_path": "fxbarcode/oned/BC_OneDimWriter.cpp" }, { "type": "modify", "old_id": "be0e068c0d9e02665eea5d6ebb9118eb5459743f", "old_mode": 33188, "old_path": "fxbarcode/oned/BC_OnedEAN13Writer.cpp", "new_id": "371dceb93d288e18e9aa7be6263a3e4e15f53d81", "new_mode": 33188, "new_path": "fxbarcode/oned/BC_OnedEAN13Writer.cpp" }, { "type": "modify", "old_id": "85c0aa652fa649ecadc26f3ee749fd9c29a44b53", "old_mode": 33188, "old_path": "fxbarcode/oned/BC_OnedEAN8Writer.cpp", "new_id": "9068667ae8767b899832bb447a3ae451d461771d", "new_mode": 33188, "new_path": "fxbarcode/oned/BC_OnedEAN8Writer.cpp" }, { "type": "modify", "old_id": "7e284cb7e3e69feb75a14731a153f3c57a41b3c0", "old_mode": 33188, "old_path": "fxbarcode/oned/BC_OnedUPCAWriter.cpp", "new_id": "89101e0cc956118fc3fe443bac21aac017f7acfd", "new_mode": 33188, "new_path": "fxbarcode/oned/BC_OnedUPCAWriter.cpp" }, { "type": "modify", "old_id": "759bb34dc1439df250c0623d59ff54a8e9950146", "old_mode": 33188, "old_path": "xfa/fde/cfde_textout_unittest.cpp", "new_id": "dc425cd27aea225011dc471bb49bce4b342585fb", "new_mode": 33188, "new_path": "xfa/fde/cfde_textout_unittest.cpp" }, { "type": "modify", "old_id": "b520bec8b0867dddbfc52bfe1645658d0f3e4578", "old_mode": 33188, "old_path": "xfa/fgas/graphics/cfgas_gegraphics.cpp", "new_id": "657878eb1dc73e159da6ec0050b28f30f05d5d80", "new_mode": 33188, "new_path": "xfa/fgas/graphics/cfgas_gegraphics.cpp" }, { "type": "modify", "old_id": "be75a09d68433cb9caa29937f7c6a225750a7f9e", "old_mode": 33188, "old_path": "xfa/fxfa/cxfa_imagerenderer.cpp", "new_id": "c40c819193dc0b5c8372c2c36892f293a107f175", "new_mode": 33188, "new_path": "xfa/fxfa/cxfa_imagerenderer.cpp" } ] }