tree a00a24fbb67ae82c193b327565bbeb97b4006335
parent af586c7099a3c341c3514afc75e431eb47798abf
author Lei Zhang <thestig@chromium.org> 1669839053 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1669839053 +0000

Remove `CFX_DIBBase::m_pAlphaMask` and some related code.

After these CLs [1] [2] [3] [4] [5] removed many unused FXDIB_Format
values, `FXDIB_Format::kArgb` is the only remaining format which has an
alpha channel. Thus CFX_DIBBase::BuildAlphaMask() is dead code because
all of its call sites are unreachable. With BuildAlphaMask() gone,
`CFX_DIBBase::m_pAlphaMask` will always to null.

Remove all `m_pAlphaMask` use in CFX_DIBBase and CFX_DIBitmap. This
leaves several CFX_DIBBase methods as stubs. Add TODOs to evaluate
callers to these stubs.

[1] https://pdfium-review.googlesource.com/75510
[2] https://pdfium-review.googlesource.com/75531
[3] https://pdfium-review.googlesource.com/75532
[4] https://pdfium-review.googlesource.com/75533
[5] https://pdfium-review.googlesource.com/75550

Change-Id: I81a5be5aae166048efbceecc5533caf20d68872d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101850
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>