)]}'
{
  "commit": "fe08482976fb43cc93e4f8a3ea799d98dfe96ada",
  "tree": "d4e72584a31ccf49859490121ddb83df7753cf10",
  "parents": [
    "8dee6cab8f10a257d3b551ede6ca85466bf0bac7"
  ],
  "author": {
    "name": "Nico Weber",
    "email": "thakis@chromium.org",
    "time": "Wed Jul 30 14:16:25 2014 -0700"
  },
  "committer": {
    "name": "Nico Weber",
    "email": "thakis@chromium.org",
    "time": "Wed Jul 30 14:16:25 2014 -0700"
  },
  "message": "Fix incorrect override of GetLayoutOrder().\n\nfsdk_baseform.h:63:19: error: \u0027CPDFSDK_Widget::GetLayoutOrder\u0027 hides overloaded virtual function [-Werror,-Woverloaded-virtual]\n        virtual int                                             GetLayoutOrder() {return 2;}\n                                                                ^\nfsdk_baseannot.h:70:18: note: hidden overloaded virtual function \u0027CPDFSDK_Annot::GetLayoutOrder\u0027 declared here: different qualifiers (const vs none)\n        virtual int                                     GetLayoutOrder() const { return 5; }\n                                                        ^\n\nOn Windows, I believe MSVS treats these as override since it\u0027s such a common and\neasy mistake, but clang and gcc do what the standard specifies. Add a \"const\" to\nthe function in the subclass so that this is actually an override, as intended.\n\nBUG\u003dpdfium:29\nR\u003dbo_xu@foxitsoftware.com\n\nReview URL: https://codereview.chromium.org/427173002\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b93cbbd81fa2b3ea28ce78aedad18f3d4619bb83",
      "old_mode": 33188,
      "old_path": "fpdfsdk/include/fsdk_baseform.h",
      "new_id": "073c99f199b2d3ee0748ee5a35c06e593d4fdd9f",
      "new_mode": 33188,
      "new_path": "fpdfsdk/include/fsdk_baseform.h"
    }
  ]
}
