tree b0b1f8c12b1b92ac7b0c495e5f4785edff33cbed
parent 5a2ef2757c25a55012bd3e7e0647a6723e91915b
author Tom Sepez <tsepez@chromium.org> 1565900108 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1565900108 +0000

Replace PDF_ENABLE_XFA with an interface in CFXJS_Engine.

Then remove some JS calls from fpdfsdk when fxjs/xfa wants to interact
with fxjs/non-xfa, merely returning the reference itself. In turn,
we are now passing V8 locals, so the lifetime of the handle scope
must increase in the callers.

Also remove an ifdef from messages just to get more similarity
between xfa/non-xfa at the cost of a few bytes of string.

The result is no more PDF_ENABLE_XFA in fjxs.

-- Remove unused ChangeObjName().
-- Set result to undefined at method start so early returns are safer.
-- Always set up handle/isolate scopes prior to defining objects, even
   though it may not be strictly required for non-xfa.

Change-Id: Ie69077cca17d132122050073f15743ffdd1a4e07
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59257
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>