)]}' { "commit": "6f34355e9d091fd4e031e9354fdfa778000b0d4a", "tree": "837088269e45b19aff2196800bc72f705a83ea50", "parents": [ "455019ca48f60bd285e043986471f51f17c69a0d" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Sep 16 13:53:42 2015 -0700" }, "committer": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Sep 16 13:53:42 2015 -0700" }, "message": "Make pdfium_embeddertests link in debug component builds.\n\nTarget v8 has:\n\n \u0027direct_dependent_settings\u0027: {\n \u0027defines\u0027: [\n \u0027V8_SHARED\u0027,\n \u0027USING_V8_SHARED\u0027,\n ],\n },\n\nFor this to work, targets using v8 headers have to depend on v8\ndirectly, else the V8_EXPORT macro won\u0027t work. Add a direct\ndependency on v8.\n\nBUG\u003dnone\nTEST\u003ddo a debug component build of pdfium_embeddertests on Win,\nshould work without linker errors\n\nR\u003dtsepez@chromium.org\n\nReview URL: https://codereview.chromium.org/1349843002 .\n", "tree_diff": [ { "type": "modify", "old_id": "17276e0744a57f7eecf04b8d3b5ba26a6ccbc9c3", "old_mode": 33188, "old_path": "BUILD.gn", "new_id": "bba48180a910d246ed6e2939219951db4a12fb0a", "new_mode": 33188, "new_path": "BUILD.gn" }, { "type": "modify", "old_id": "5c8799e9a5e5c2e7ac4a8ccd5166054a975b122b", "old_mode": 33188, "old_path": "pdfium.gyp", "new_id": "12314d7e93b02d8dade7122eb3833c524d70c6e9", "new_mode": 33188, "new_path": "pdfium.gyp" } ] }