)]}' { "commit": "3f148915d12f54a946a0c0bf526162b79c39d650", "tree": "17a95f27c8a6a07356b68ac41b5fbcc0f2358ab9", "parents": [ "76c6d639f46c37ba955569f507201eb3f1b613fc" ], "author": { "name": "Dan Sinclair", "email": "dsinclair@chromium.org", "time": "Mon Nov 16 12:28:39 2015 -0500" }, "committer": { "name": "Dan Sinclair", "email": "dsinclair@chromium.org", "time": "Mon Nov 16 12:28:39 2015 -0500" }, "message": "Reland \"Cleanup some numeric code.\"\"\n\nThis reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.\n\nThis changes the various comparisons of char \u003e\u003d \u00270\u0027 \u0026\u0026 char \u003c\u003d \u00279\u0027 and\nchar \u003c \u00270\u0027 || char \u003e \u00279\u0027 to use std::isdigit checks. It also cleans up\na handful of hex to digit conversions to call one common method.\n\nR\u003dtsepez@chromium.org\n\nReview URL: https://codereview.chromium.org/1449873003 .\n", "tree_diff": [ { "type": "modify", "old_id": "ec16d1b5566a4000ec6240263912d2f5096a8b2f", "old_mode": 33188, "old_path": "BUILD.gn", "new_id": "f1583abaf03c6b8298af5d36c099f03c7bbf1e36", "new_mode": 33188, "new_path": "BUILD.gn" }, { "type": "modify", "old_id": "c24955fb7cb0de19b294a822a85c4671d9995bfc", "old_mode": 33188, "old_path": "core/include/fxcrt/fx_ext.h", "new_id": "f13d37caf4f99e954449fc5c09e6a95333a54d76", "new_mode": 33188, "new_path": "core/include/fxcrt/fx_ext.h" }, { "type": "modify", "old_id": "9f83da062c2802ee5c148a0648084e206421f415", "old_mode": 33188, "old_path": "core/src/fpdfapi/fpdf_font/fpdf_font.cpp", "new_id": "64d6cdce92a89698d4240c6a73572efc2242ac30", "new_mode": 33188, "new_path": "core/src/fpdfapi/fpdf_font/fpdf_font.cpp" }, { "type": "modify", "old_id": "65b4b781b1411c188f7990f42eb4f39f23ec4f21", "old_mode": 33188, "old_path": "core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp", "new_id": "d4c71085a1af2f7f16de2c425e027b1c9be5e9db", "new_mode": 33188, "new_path": "core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp" }, { "type": "modify", "old_id": "8d155e787b97c731e77feef064be752fec631fd6", "old_mode": 33188, "old_path": "core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp", "new_id": "a1aa686248000731f12eebc014ac2d65828425b1", "new_mode": 33188, "new_path": "core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp" }, { "type": "modify", "old_id": "588ab5dff620428a542d9e099651c70ef5e6483d", "old_mode": 33188, "old_path": "core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp", "new_id": "57d19718897e364250631627367961c7e1545587", "new_mode": 33188, "new_path": "core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp" }, { "type": "modify", "old_id": "6e927e1a88739c5c73e1af6992d94f88b48f3121", "old_mode": 33188, "old_path": "core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp", "new_id": "6251748d3ea1794f0bcff63694e4720cadf2b2d3", "new_mode": 33188, "new_path": "core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp" }, { "type": "modify", "old_id": "89a5deb62d03655fd0c3d0d0997e8e30ba1891ed", "old_mode": 33188, "old_path": "core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp", "new_id": "9729bab9424888ebb7291d066984690879746eb0", "new_mode": 33188, "new_path": "core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp" }, { "type": "modify", "old_id": "55ab4837221d1c7ea3c7c2c281ece957d31977fa", "old_mode": 33188, "old_path": "core/src/fpdftext/fpdf_text.cpp", "new_id": "0b7a849c7560bd64dc3261f509cc01e7185286d8", "new_mode": 33188, "new_path": "core/src/fpdftext/fpdf_text.cpp" }, { "type": "modify", "old_id": "dd6be313ba849afe3ee343dcc407419659fb0129", "old_mode": 33188, "old_path": "core/src/fpdftext/fpdf_text_int.cpp", "new_id": "4ed11e3986cb757183939f4947f873a6176833cf", "new_mode": 33188, "new_path": "core/src/fpdftext/fpdf_text_int.cpp" }, { "type": "modify", "old_id": "bfa5befce433eedff5e3bbe0122b033a6562b340", "old_mode": 33188, "old_path": "core/src/fxcodec/codec/fx_codec.cpp", "new_id": "51a1f5d55c64dc8398b8d318412808307c90ff25", "new_mode": 33188, "new_path": "core/src/fxcodec/codec/fx_codec.cpp" }, { "type": "modify", "old_id": "9d64fbe1392cbb2453a04f89bda5fd0fdbd3361e", "old_mode": 33188, "old_path": "core/src/fxcrt/fx_basic_bstring.cpp", "new_id": "574e57a9a64058990726b7857b9bfb7aabb81424", "new_mode": 33188, "new_path": "core/src/fxcrt/fx_basic_bstring.cpp" }, { "type": "modify", "old_id": "f8b0c7ac78e21e1ee9ca68b6c21559db9619798a", "old_mode": 33188, "old_path": "core/src/fxcrt/fx_basic_gcc.cpp", "new_id": "c352ee3f81a3b1ff87ed298aa5d52e060481e232", "new_mode": 33188, "new_path": "core/src/fxcrt/fx_basic_gcc.cpp" }, { "type": "modify", "old_id": "3e9d6169cdcf7bccfd35ff92d646f97656c76c27", "old_mode": 33188, "old_path": "core/src/fxcrt/fx_basic_util.cpp", "new_id": "b4c7064da2c945e806506ceef74a4c06ac831c9f", "new_mode": 33188, "new_path": "core/src/fxcrt/fx_basic_util.cpp" }, { "type": "modify", "old_id": "131672da2b280938d339d81384c3ccca68cf8bd6", "old_mode": 33188, "old_path": "core/src/fxcrt/fx_basic_wstring.cpp", "new_id": "220ffbd57dad029884997333412f4085a04bf959", "new_mode": 33188, "new_path": "core/src/fxcrt/fx_basic_wstring.cpp" }, { "type": "modify", "old_id": "7eb86d636421303ad480fc53e346b94e4d56809b", "old_mode": 33188, "old_path": "core/src/fxcrt/fx_extension.cpp", "new_id": "37437ae9ed587e91c6d7e3b193d197f216c9b898", "new_mode": 33188, "new_path": "core/src/fxcrt/fx_extension.cpp" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "b12dcbe07f405fefea2e375018e85475cf6b9f9c", "new_mode": 33188, "new_path": "core/src/fxcrt/fx_extension_unittest.cpp" }, { "type": "modify", "old_id": "429bc38289ad8581d2f6c6b4d3bc18e9532181b1", "old_mode": 33188, "old_path": "core/src/fxcrt/fx_xml_parser.cpp", "new_id": "2d3ff6631ec3508e6dca80986568909dabb14f72", "new_mode": 33188, "new_path": "core/src/fxcrt/fx_xml_parser.cpp" }, { "type": "modify", "old_id": "f6ead75f9fd73685a0d67cc62dd8866a57c2918a", "old_mode": 33188, "old_path": "fpdfsdk/src/fsdk_baseannot.cpp", "new_id": "8cd3df97c0fca00e9104322037e32058fe72838e", "new_mode": 33188, "new_path": "fpdfsdk/src/fsdk_baseannot.cpp" }, { "type": "modify", "old_id": "cd71e7074ca8f04c3f82d975df787997bd20792d", "old_mode": 33188, "old_path": "fpdfsdk/src/javascript/PublicMethods.cpp", "new_id": "094f3e7dd7e02dae390af11b143ab7e52881a065", "new_mode": 33188, "new_path": "fpdfsdk/src/javascript/PublicMethods.cpp" }, { "type": "modify", "old_id": "c021ec9e9552ea8a5854bfde47b893a6c00a3da3", "old_mode": 33188, "old_path": "fpdfsdk/src/javascript/util.cpp", "new_id": "30df53ea7292ee4a5010fd070179d7301a2ceac9", "new_mode": 33188, "new_path": "fpdfsdk/src/javascript/util.cpp" }, { "type": "modify", "old_id": "0bf0742f0e0efa8f75123cd9f1e7bc811d3c9ee2", "old_mode": 33188, "old_path": "pdfium.gyp", "new_id": "58d6b8ffcd080d49857ac815b4e3b5a6d6c42a55", "new_mode": 33188, "new_path": "pdfium.gyp" } ] }