)]}' { "commit": "628f7053cc646c58c61add247c75bc65ac135327", "tree": "2ddc74d0849be476e6b6ef915bc791e5f03ed426", "parents": [ "1fb4bc47e216c9caebdf7bc8479d45285ee7693b" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Nov 25 10:29:58 2015 -0800" }, "committer": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Nov 25 10:29:58 2015 -0800" }, "message": "CFXJS_ObjDefinition\u0027s lifetime must match isolate.\n\nIntroduced at https://codereview.chromium.org/1424933013/\n\nThe v8 objects are 1:1 with the context being destroyed in\nFXJS_ReleaseRuntime, but the CFXJS_ObjDefinitions are still\n1:1 with the isolate, so they can\u0027t be destroyed until the\nrefcounts hit zero.\n\nBUG\u003d561184\nR\u003djochen@chromium.org\n\nReview URL: https://codereview.chromium.org/1468423004 .\n", "tree_diff": [ { "type": "modify", "old_id": "4e069d52a33f5d0f4f43f6bd90eaa318cbef2a55", "old_mode": 33188, "old_path": "fpdfsdk/src/jsapi/fxjs_v8.cpp", "new_id": "ed8e2e856304bb9c8fe50e06f151f29c8381a16e", "new_mode": 33188, "new_path": "fpdfsdk/src/jsapi/fxjs_v8.cpp" } ] }