)]}' { "commit": "1e1d3b0f2bc6b6c185b37e0aa6b8663e901dc8bf", "tree": "56197c6d5664950ce17eb42224523e13b6b2c103", "parents": [ "2398d8938277a2492b411f8f807bf1935918ccae" ], "author": { "name": "Oliver Chang", "email": "ochang@chromium.org", "time": "Wed Feb 17 16:51:56 2016 -0800" }, "committer": { "name": "Oliver Chang", "email": "ochang@chromium.org", "time": "Wed Feb 17 16:51:56 2016 -0800" }, "message": "Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.\n\nThe parser did not expect an invalid token in some places, leading to an\ninfinite loop.\n\nIn the lexer, if an invalid string was found, the underlying pointer was\nnever advanced.\n\nAlso cleans some minor stuff along the way:\n- Remove nonsensical/useless destructors\n- Use unique_ptrs for owned members\n- Remove unused members\n- Other minor style changes\n\nBUG\u003d587620\nR\u003dtsepez@chromium.org\n\nReview URL: https://codereview.chromium.org/1701363003 .\n", "tree_diff": [ { "type": "modify", "old_id": "9a01267e2794e6babf64cce9bc74dfc41302bf4b", "old_mode": 33188, "old_path": "xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp", "new_id": "105c5144ca5dd0b7691da9f9ef4beaa85ec2e67c", "new_mode": 33188, "new_path": "xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp" }, { "type": "modify", "old_id": "45cd3db647116e8b0432e136911f31e1aff4d52e", "old_mode": 33188, "old_path": "xfa/src/fxfa/src/fm2js/xfa_fmparse.h", "new_id": "ed950c5aa4a706d56369da25a4bda0bfb2d8664a", "new_mode": 33188, "new_path": "xfa/src/fxfa/src/fm2js/xfa_fmparse.h" }, { "type": "modify", "old_id": "8ecc85b4b7cfb2d0d745f56988bfb3010e68cea5", "old_mode": 33188, "old_path": "xfa/src/fxfa/src/fm2js/xfa_lexer.cpp", "new_id": "957c21b87418d0c5ddf895aaeab596bba7128084", "new_mode": 33188, "new_path": "xfa/src/fxfa/src/fm2js/xfa_lexer.cpp" }, { "type": "modify", "old_id": "85b647e46ccf13e06f76e9733f6e1cafaa08486b", "old_mode": 33188, "old_path": "xfa/src/fxfa/src/fm2js/xfa_lexer.h", "new_id": "14b927d6d93b199eacd1a405091d612d92daa876", "new_mode": 33188, "new_path": "xfa/src/fxfa/src/fm2js/xfa_lexer.h" } ] }