)]}' { "commit": "bb5fa043a7ef2de165c7903548e5663a6f8bcf9a", "tree": "97d7fcec70171f9d12d2d613486e140d72eb1baa", "parents": [ "fb606f2723b87a145a9ceece6cd6ccaaf15ceadd" ], "author": { "name": "tonikitoo", "email": "tonikitoo@igalia.com", "time": "Fri Aug 19 11:18:29 2016 -0700" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 19 11:18:29 2016 -0700" }, "message": "Stub out Document::syncAnnotScan method.\n\nThe PDF specification [1] says:\n\n\"\nsyncAnnotScan guarantees that all annotations will be scanned\nby the time this method returns.\n(..)\nNormally a background task runs that examine every page and\nlooks for annotations during idle times.\n\"\n\nThe statement details specifically how Acrobat implements\nthis method.\nAlthough, neither the method itself nor the background scanner\ntask are implemented in PDFium (as of today, Ago/2016),\nnot having ::syncAnnotScan at least stubbed out can be considered\nharmfull since its absence makes JS acrobat scripts silently\nfail when it has a call to it.\n\nGiven that, and following a stub-out pattern present in other\nmethods including ::addAnnot and ::addField, CL provides\na stubbed out implementation of Document::syncAnnotScan.\n\n[1] http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_api_reference.pdf\n\nBUG\u003dpdfium:492\n\nReview-Url: https://codereview.chromium.org/2265553002\n", "tree_diff": [ { "type": "modify", "old_id": "8fb07b085b2c05f17315aafae3fdd87624073af7", "old_mode": 33188, "old_path": "fpdfsdk/javascript/Document.cpp", "new_id": "8fb9ce60dc5433c32e11c6f0b8b657059ebbd141", "new_mode": 33188, "new_path": "fpdfsdk/javascript/Document.cpp" }, { "type": "modify", "old_id": "1c20ac42215e74fd20dc9a21bee421a951c86ffe", "old_mode": 33188, "old_path": "fpdfsdk/javascript/Document.h", "new_id": "feef228c6e5a1d165682ea54e280a4e5499844a8", "new_mode": 33188, "new_path": "fpdfsdk/javascript/Document.h" }, { "type": "modify", "old_id": "bc0f3f11263598ca1c4726f11c03327ecba2e6fc", "old_mode": 33188, "old_path": "testing/resources/javascript/document_methods.in", "new_id": "cdbd6845c84e35ffd5a282612f180dc59904878e", "new_mode": 33188, "new_path": "testing/resources/javascript/document_methods.in" }, { "type": "modify", "old_id": "ed601f279b20a4d0295ae24dd35a7367e3c42ebb", "old_mode": 33188, "old_path": "testing/resources/javascript/document_methods_expected.txt", "new_id": "70a7481708780687904900e7474aae0738847240", "new_mode": 33188, "new_path": "testing/resources/javascript/document_methods_expected.txt" } ] }