)]}' { "commit": "32489a0eb4b5b71e7951c1e165e69209655eacee", "tree": "69fb566b9e186bb5e46178ad707b6f42f41f533f", "parents": [ "8a1081fbf7f9fac94b32c59b5851387abdd24dea" ], "author": { "name": "Ryan Harrison", "email": "rharrison@chromium.org", "time": "Tue Aug 22 16:58:46 2017 -0400" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 22 21:32:26 2017 +0000" }, "message": "Bypass asserts in string [] operator for empty strings\n\nThe previous behaviour of [] on an empty string was to return 0\nregardless of the index. We wanted to make this more strict, hence the\ncurrent behaviour. This has led to a number of crashes due to code\ndepending on the old behaviour. Reverting to the old behaviour until\nwe have time to correct the call sites using empty strings.\n\nBug\u003dchromium:752480, pdfium:828\n\nChange-Id: I511eea4148de85bf7f4694351e7a030b1a37f0de\nReviewed-on: https://pdfium-review.googlesource.com/11630\nCommit-Queue: Ryan Harrison \u003crharrison@chromium.org\u003e\nReviewed-by: Nicolás Peña \u003cnpm@chromium.org\u003e\nReviewed-by: dsinclair \u003cdsinclair@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "3e8b6619c210035223b1c79d4e246b8c807efeda", "old_mode": 33188, "old_path": "core/fxcrt/cfx_bytestring.h", "new_id": "0e8e006a3c37a59c6775dd970f70dcb7dee6e2e1", "new_mode": 33188, "new_path": "core/fxcrt/cfx_bytestring.h" }, { "type": "modify", "old_id": "d57e47c62f1c756babacf3e65904ec4708a17f26", "old_mode": 33188, "old_path": "core/fxcrt/cfx_widestring.h", "new_id": "f9e800d0a28bd216d6b1fc2e3a2aa7f636c854c4", "new_mode": 33188, "new_path": "core/fxcrt/cfx_widestring.h" } ] }