)]}' { "commit": "ed48c1a42b2f9a0c8cb04185c180c6424bad3b83", "tree": "34745df62b9982021dfa990b1cec824674033236", "parents": [ "175a8588f4290df8ec32d697c0248eb5c6b2c396" ], "author": { "name": "Ryan Harrison", "email": "rharrison@chromium.org", "time": "Fri Aug 25 15:34:41 2017 -0400" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 25 19:57:25 2017 +0000" }, "message": "Add help IsValid* methods to string classes\n\nThe various string classes, CFX_ByteString, CFX_ByteStringC,\nCFX_WideString, and CFX_WideStringC, have many conditionals that are\neffectively determining if a value is a valid index or length. This CL\nrefactors the logic into one place per class, so it only needs to be\nchanged once if its behaviour needs to change. It also make the some\nof the methods stricter on the inputs they will accept.\n\nBUG\u003dpdfium:828\n\nChange-Id: Iadcdaa34a6d862a2804485770027179c89dc6956\nReviewed-on: https://pdfium-review.googlesource.com/12030\nCommit-Queue: Ryan Harrison \u003crharrison@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "f6074e961bbe8c637f5f9be191a9c1686e49fe71", "old_mode": 33188, "old_path": "core/fxcrt/cfx_bytestring.cpp", "new_id": "ac390949ee3dd8190c0925a9ee068bbdd904f28e", "new_mode": 33188, "new_path": "core/fxcrt/cfx_bytestring.cpp" }, { "type": "modify", "old_id": "10675be7a5d2b418249801b492513b1d3f50d7f2", "old_mode": 33188, "old_path": "core/fxcrt/cfx_bytestring.h", "new_id": "a8a28169a527609e623d1ee1defee7b440fb39be", "new_mode": 33188, "new_path": "core/fxcrt/cfx_bytestring.h" }, { "type": "modify", "old_id": "e7281546fbe2c76f160a0bf8115ee3fea37e4e9f", "old_mode": 33188, "old_path": "core/fxcrt/cfx_bytestring_unittest.cpp", "new_id": "497e0b6c2f164152e6471e46af522b90e064da44", "new_mode": 33188, "new_path": "core/fxcrt/cfx_bytestring_unittest.cpp" }, { "type": "modify", "old_id": "db8b27441084116f9cff882ea6fe8b303b980d4b", "old_mode": 33188, "old_path": "core/fxcrt/cfx_string_c_template.h", "new_id": "c46b0c4671b67f7a067905dedbf5264b11c1eefb", "new_mode": 33188, "new_path": "core/fxcrt/cfx_string_c_template.h" }, { "type": "modify", "old_id": "76fdf24b2cfdf07f6b6dfdabc7496c2d496bfabe", "old_mode": 33188, "old_path": "core/fxcrt/cfx_widestring.cpp", "new_id": "6e4e82d09df2a6330e618f9832463e49d71b5fca", "new_mode": 33188, "new_path": "core/fxcrt/cfx_widestring.cpp" }, { "type": "modify", "old_id": "a6d0eca04467bfaf31062769d7ad13192b620050", "old_mode": 33188, "old_path": "core/fxcrt/cfx_widestring.h", "new_id": "242138853b4d793720b8e2c4e8e19c932742eba8", "new_mode": 33188, "new_path": "core/fxcrt/cfx_widestring.h" }, { "type": "modify", "old_id": "e688a5334e953c379621b54ada369725f09dc7e1", "old_mode": 33188, "old_path": "core/fxcrt/cfx_widestring_unittest.cpp", "new_id": "0005cb3754d2792a949243b35ee6eaba1128ec94", "new_mode": 33188, "new_path": "core/fxcrt/cfx_widestring_unittest.cpp" }, { "type": "modify", "old_id": "95a95b69e23d039cfd2a9364e5a63a6bae6e363d", "old_mode": 33188, "old_path": "fxbarcode/oned/BC_OnedCode128Writer.cpp", "new_id": "a6dc749a769ddc2756111e2fdd6e1e0a22e1798c", "new_mode": 33188, "new_path": "fxbarcode/oned/BC_OnedCode128Writer.cpp" } ] }