tree e8fb878b806b96d795a30206347669e709ee29bf
parent 7558414b8aa1d14ce02e360dd88e4f421cee8725
author Ryan Harrison <rharrison@chromium.org> 1504293072 -0400
committer Chromium commit bot <commit-bot@chromium.org> 1504293784 +0000

Cleanup usages of Mid(foo, 1), Right(1), and Left(1)

Mid(foo, 1) is equivalent to [foo], if all you want is the character. Similarly
Left(1) is [0]. It is faster also, since it does not need to create intermediate
strings.

Right(1) is a touch more tricky, since it requires something like GetLength() ?
[GetLength() - 1] : 0;. A new method, Last() has been added to perform this
character extraction.

Multiple call sites have been updated to use more efficient/simpler
syntax. There are a number of call sites that use on these patterns, but based
on the surrounding context we actually need/want a string, so they have not been
modified.

Change-Id: I485a7f9c7b34c9bdacecada610158f996816afdd
Reviewed-on: https://pdfium-review.googlesource.com/12890
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>