)]}' { "commit": "507fb4ed09d5fbc92fafdfe405d79d44d11a4664", "tree": "136d003fdefa3ad7fd707af180c161713108ffd2", "parents": [ "f19255a1deec5f3ce804b08901abf7746e609bfe" ], "author": { "name": "dan sinclair", "email": "dsinclair@chromium.org", "time": "Thu Mar 08 15:14:09 2018 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 08 15:14:09 2018 +0000" }, "message": "Convert Before{Selection|Value}Change to return a bool\n\nBoth of these IPDF_FormNotify methods return {-1, 0, 1} but all\ncallsites only care about \u003c 0 and \u003e\u003d 0. Convert to return a bool that\ntreats the 0 and 1 case as the same.\n\nThis also makse sense in terms of the API because false means validation\nfailure. The case where 0 was used was a place holder for we didn\u0027t try\nfor this field type, which also implicitly means validation passed.\n\nChange-Id: I0950c678191b83caffd755d4a87b2f0efee71c89\nReviewed-on: https://pdfium-review.googlesource.com/28192\nCommit-Queue: Ryan Harrison \u003crharrison@chromium.org\u003e\nReviewed-by: Ryan Harrison \u003crharrison@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "686054f9f1714f5e2e7487babb1939241beecc0d", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_formfield.cpp", "new_id": "679acd1dc8f9bf10d577ff05cd955d4051d94362", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_formfield.cpp" }, { "type": "modify", "old_id": "c8440eac00c08e141e227dbb378842554ca08792", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_interform.cpp", "new_id": "2fbc3aa32aa2dce6c451c4aedcb0268a62e5c716", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_interform.cpp" }, { "type": "modify", "old_id": "10a97a0d88f112bdfbc3a10b5b44f5567c6aea5b", "old_mode": 33188, "old_path": "core/fpdfdoc/ipdf_formnotify.h", "new_id": "053ca12a41c201c1a38d92ddf03545bbdc1a553d", "new_mode": 33188, "new_path": "core/fpdfdoc/ipdf_formnotify.h" }, { "type": "modify", "old_id": "94c9b234731fbe661adaf166d86eade7d338df5e", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_interform.cpp", "new_id": "57f3a6e90e48eb8a4b49a5188e6a36e0613bd01a", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_interform.cpp" }, { "type": "modify", "old_id": "893b60168b53bee7b39ff24b018ad9da71866489", "old_mode": 33188, "old_path": "fpdfsdk/cpdfsdk_interform.h", "new_id": "58dc2d0993e5d20e147e522ad19cf8adf651cfa2", "new_mode": 33188, "new_path": "fpdfsdk/cpdfsdk_interform.h" } ] }