)]}' { "commit": "dd2a629f9ede484e0e570ce09d1e9d8906aa11be", "tree": "d8ef3690e1f888a62141fa3e12224c8be554aff6", "parents": [ "e61e2f3d34efee51b69838646dd4e7462989ca08" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Apr 20 19:14:53 2018 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 20 19:14:53 2018 +0000" }, "message": "Add CPDF_PatternCS::GetPatternRGB(const PatternValue\u0026 value).\n\nCurrently, one gets data from CPDF_PatternCS via its parent class\u0027s\nGetRGB(const float* pBuf) method. To squeeze through this interface, the\ncaller has to pass in a float*, and CPDF_PatternCS::GetRGB() has to cast\nit to PatternValue*.\n\nInstead of doing casting, add a specialized GetPatternRGB() method to\nCPDF_PatternCS. In its parent class, CPDF_ColorSpace, add AsPatternCS()\nso callers can get a CPDF_PatternCS* from a CPDF_ColorSpace*. Change\nexisting callers to use these new methods.\n\nChange-Id: Id476c9ece7ce8d3499a718acc682bc25036a5407\nReviewed-on: https://pdfium-review.googlesource.com/31030\nReviewed-by: Henrique Nakashima \u003chnakashima@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "dfee9d93ca43f223f53dbbe39a2f4836e364cb07", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_color.cpp", "new_id": "b3dd141103d5e1c07978f87c00318821cb09cfe0", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_color.cpp" }, { "type": "modify", "old_id": "8ba2d8b4d5fb43927595ada10c86531883aea876", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_colorspace.cpp", "new_id": "3cdc96a000fb90dfb3ea51dc5a28126906bca036", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_colorspace.cpp" }, { "type": "modify", "old_id": "b9879d135c8d3365abf37c937c1b518fecb76eba", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_colorspace.h", "new_id": "71722224aabb02f5d6a18539a0a3ac327b576c93", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_colorspace.h" }, { "type": "modify", "old_id": "5da176984bccbd7f8b6920e1ddfffce92ca9081e", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_patterncs.cpp", "new_id": "37e91aa4e0f769f3d908ae9ec0b05cc4724b6f4d", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_patterncs.cpp" }, { "type": "modify", "old_id": "488c83da4a40ce9678128061939fcc4a0d448b85", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_patterncs.h", "new_id": "45365cc7380856f7e6ba816ec753b05badddf466", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_patterncs.h" } ] }