)]}'
{
  "commit": "1118a66bfe024e137324075ac4d9433b9425e373",
  "tree": "54b52b97df28789dd22c1619ef96d67d8ac0d77f",
  "parents": [
    "9bff799490de4ac9da53d708f547d106f28d5c72"
  ],
  "author": {
    "name": "Ryan Harrison",
    "email": "rharrison@chromium.org",
    "time": "Thu May 31 19:26:52 2018 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu May 31 19:26:52 2018 +0000"
  },
  "message": "Make XFA pixel tests more stable\n\nWhen generating PDFs using the fixup script and a .in, specify them to\nto use Ahem.ttf as the text font. Ahem is a font designed to reduce\nflakiness in pixel tests due to font rendering differences between\nplatforms. Specifically the glyphs in the font are standard size black\nboxes, so though the specific text content cannot be easily compared,\nthings like layout and high level changes to the content can still\nbe tested. Testing things like specific text changes should be done\nvia an embedder test, where the strings in the elements can be\nextracted and inspected.\n\nThe font itself is is CID type 2 font, which is relatively complex to\ncorrectly embed in a PDF due to subsetting and other features. Instead\nof embedding it in the generated PDFs, which was originally attempted,\nit is being supplied to pdfium_test via the --font-dir flag. This flag\noverrides where the binary looks for system fonts. This works\ncorrectly on Mac and Linux, but not on Windows, which is why that\nplatform remains suppressed.\n\nBUG\u003dpdfium:1008,pdfium:1020\n\nChange-Id: I00811536de98f736fc599d96b397194ccf8db0cd\nReviewed-on: https://pdfium-review.googlesource.com/27790\nCommit-Queue: Ryan Harrison \u003crharrison@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "62d7c735b0de761e1b5bb94711cc30d26599bb9e",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cfx_systemhandler.cpp",
      "new_id": "99aff8c6f800f8e0d778ea81f121c54cc7d8b26c",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cfx_systemhandler.cpp"
    },
    {
      "type": "modify",
      "old_id": "7633e04a484a9867b69081ad9436528f7c5f1aad",
      "old_mode": 33188,
      "old_path": "testing/SUPPRESSIONS",
      "new_id": "cb6b9bfbe32c1b611e46621b6afea2f87b5df996",
      "new_mode": 33188,
      "new_path": "testing/SUPPRESSIONS"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "4d4785a4123287a5ca08439a6230514de91df0e7",
      "new_mode": 33188,
      "new_path": "testing/resources/fonts/Ahem.ttf"
    },
    {
      "type": "rename",
      "old_id": "d8be96f305773a758f30ff06809ec2a9a738bb1a",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_example.in",
      "new_id": "0e9ac151d5c04f8b5ab7523ca633b59612d6e236",
      "new_mode": 33188,
      "new_path": "testing/resources/pixel/xfa_specific/use_ahem/xfa_example.in",
      "score": 95
    },
    {
      "type": "rename",
      "old_id": "9a682f7186d84271e961bbece5b52a1586794cd4",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_example_expected_mac.pdf.0.png",
      "new_id": "e1e62cce18d4dcab577c99a3175e22a2a1482a11",
      "new_mode": 33188,
      "new_path": "testing/resources/pixel/xfa_specific/use_ahem/xfa_example_expected.pdf.0.png",
      "score": 63
    },
    {
      "type": "rename",
      "old_id": "3d110568ec18204d7c0b8dc262cf6d0dc4e920a6",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_textfield.evt",
      "new_id": "127946800638f0babdf2dd12ed1891ca5d38f6bc",
      "new_mode": 33188,
      "new_path": "testing/resources/pixel/xfa_specific/use_ahem/xfa_textfield.evt",
      "score": 82
    },
    {
      "type": "rename",
      "old_id": "bdd685009ff50a3a018bcd99882c09102387c9f7",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_textfield.in",
      "new_id": "218dbcec96f0e5b7a21c8513f12f7d8075c8d917",
      "new_mode": 33188,
      "new_path": "testing/resources/pixel/xfa_specific/use_ahem/xfa_textfield.in",
      "score": 61
    },
    {
      "type": "rename",
      "old_id": "c4d4ce5a226b0ce99c8b2db69cde36df02687998",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_textfield_expected_mac.pdf.0.png",
      "new_id": "4d9a934c11fbf2ad75acdc25c0e022b2409d8417",
      "new_mode": 33188,
      "new_path": "testing/resources/pixel/xfa_specific/use_ahem/xfa_textfield_expected.pdf.0.png",
      "score": 68
    },
    {
      "type": "delete",
      "old_id": "81c317a1e7fc8358b330e34cc9b1692fef14a528",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_example_expected.pdf.0.png",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "9a682f7186d84271e961bbece5b52a1586794cd4",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_example_expected_win.pdf.0.png",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "e5ad5012cd49164416d6212f4341320e94780bc8",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_textfield_expected.pdf.0.png",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "c4d4ce5a226b0ce99c8b2db69cde36df02687998",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/xfa_specific/xfa_textfield_expected_win.pdf.0.png",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "bee7a3d00261d0f256846d27bb958396a54915e3",
      "old_mode": 33261,
      "old_path": "testing/tools/fixup_pdf_template.py",
      "new_id": "0f536785c1f98f950fb46770a80dcea935f840ef",
      "new_mode": 33261,
      "new_path": "testing/tools/fixup_pdf_template.py"
    },
    {
      "type": "modify",
      "old_id": "3fa1c79e04b6f3ec78b9adef34d71a96ad46d585",
      "old_mode": 33188,
      "old_path": "testing/tools/test_runner.py",
      "new_id": "3737969fb2cfb070ed4b1f373622f2d05e078d2f",
      "new_mode": 33188,
      "new_path": "testing/tools/test_runner.py"
    },
    {
      "type": "modify",
      "old_id": "354db0be43d9578e275d238862aa39295734210a",
      "old_mode": 33188,
      "old_path": "xfa/fgas/font/cfgas_fontmgr.cpp",
      "new_id": "abd5aa716a0392416e19ddd02f190d4c3418d505",
      "new_mode": 33188,
      "new_path": "xfa/fgas/font/cfgas_fontmgr.cpp"
    }
  ]
}