)]}' { "commit": "28cfe34a89f29e05f6f05356800f4f43ae241a24", "tree": "1f86d883de0a85f36cc248ec3e04131139ceddfd", "parents": [ "7802e2aa2770276ac1597e79659ead995bae9f5b" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jan 16 19:54:00 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 16 19:54:00 2019 +0000" }, "message": "Remove unreachable code paths in cxfa_document_parser.cpp\n\n- UserPacketLoader() is a no-op.\n- FindAttributeWithNS() is always called with a valid element and\n the default bMatchAsNSPrefix argument.\n- Remove out parameter from FindAttributeWithNS() in favor of\n Optional\u003c\u003e while we\u0027re at it.\n\nChange-Id: I9eb65b714b637677b3045ea20491fecf64d8e839\nReviewed-on: https://pdfium-review.googlesource.com/c/48410\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "1ab2c2112c36d87c67c01ce81ea7833a557ec53c", "old_mode": 33188, "old_path": "xfa/fxfa/parser/cxfa_document_parser.cpp", "new_id": "ace9bb440cdb26e2fe88026b1b65c0e1aa283766", "new_mode": 33188, "new_path": "xfa/fxfa/parser/cxfa_document_parser.cpp" }, { "type": "modify", "old_id": "28b8d617935c46489b849bf60edcc65bb86947a1", "old_mode": 33188, "old_path": "xfa/fxfa/parser/cxfa_document_parser.h", "new_id": "ad8d56c62d4bbfa9a3666f0cd607a35b4aae6971", "new_mode": 33188, "new_path": "xfa/fxfa/parser/cxfa_document_parser.h" } ] }