commit 17d55b5dc9ce5e682183fec017bd6e70e67e3b1f
author Tom Sepez <tsepez@chromium.org> Mon Mar 25 23:46:26 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Mar 25 23:46:26 2019 +0000
tree d152bcd365c760b4d04d728ac962d0bc9076ad2d
parent 7dd55031b9dbf0cb7fde53ca6f55d8f8ebcf13cd

Avoid bad index ASSERT() in CFGAS_StringFormatter::FormatNum

For some reason, the code was concatenating the first character of a
string followed by all the remaining characters of that string. This
is the same as the original string, except when it is empty, in which
case it trips an ASSERT. Just use the original string, as the
computation is pointless.

Bug: 945097
Change-Id: Id26c75d61f17bd858b874f6611d13c889392b071
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52350
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

xfa/fgas/crt/cfgas_stringformatter.cpp

diff --git a/xfa/fgas/crt/cfgas_stringformatter.cpp b/xfa/fgas/crt/cfgas_stringformatter.cpp
index 8594e07..665d607 100644
--- a/xfa/fgas/crt/cfgas_stringformatter.cpp
+++ b/xfa/fgas/crt/cfgas_stringformatter.cpp
@@ -2160,10 +2160,9 @@
         break;
     }
   }
-  if (!bAddNeg && bNeg) {
-    *wsOutput = pLocale->GetMinusSymbol() + (*wsOutput)[0] +
-                wsOutput->Right(wsOutput->GetLength() - 1);
-  }
+  if (!bAddNeg && bNeg)
+    *wsOutput = pLocale->GetMinusSymbol() + *wsOutput;
+
   return true;
 }