)]}' { "commit": "17d55b5dc9ce5e682183fec017bd6e70e67e3b1f", "tree": "d152bcd365c760b4d04d728ac962d0bc9076ad2d", "parents": [ "7dd55031b9dbf0cb7fde53ca6f55d8f8ebcf13cd" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Mon Mar 25 23:46:26 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 25 23:46:26 2019 +0000" }, "message": "Avoid bad index ASSERT() in CFGAS_StringFormatter::FormatNum\n\nFor some reason, the code was concatenating the first character of a\nstring followed by all the remaining characters of that string. This\nis the same as the original string, except when it is empty, in which\ncase it trips an ASSERT. Just use the original string, as the\ncomputation is pointless.\n\nBug: 945097\nChange-Id: Id26c75d61f17bd858b874f6611d13c889392b071\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52350\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "8594e072d5c1eaa7fbf9f4fea5c0d85733e5278e", "old_mode": 33188, "old_path": "xfa/fgas/crt/cfgas_stringformatter.cpp", "new_id": "665d60740db88610832bb50c92e8809622244e55", "new_mode": 33188, "new_path": "xfa/fgas/crt/cfgas_stringformatter.cpp" } ] }