tree 9f750a7077c6f3a5f9a706ac2dd0f730ee8dc91e
parent e9fa6a97fea60fcacb3088a6f012fb4dd218095e
author Tom Sepez <tsepez@chromium.org> 1556064174 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1556064174 +0000

Remove potentially tree-corrupting methods from CXFA_LayoutItem.

SetParent(), SetNextSibling() and SetFirstChild() all leave the
nodes of the tree in an inconsistent state and rely on the callers
to make futher adjustments to restore consistency. Use other
methods instead.

- Tidy InsertChild() method.
- Remove a no-op cast and a needless null assignment.

Change-Id: If1a2a3b052daa38638a99f69e4aeb9d42878de18
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/53391
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>