)]}' { "commit": "021c4f87963557ccd357b256882487fae46c2671", "tree": "02b743528f112f6129fb3d7205ceb58c0c763c87", "parents": [ "09c23b1dfe43e0a7aa77f0659b410f6d35f54275" ], "author": { "name": "Patrik Weiskircher", "email": "patrik@pspdfkit.com", "time": "Thu Apr 25 18:32:13 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 25 18:32:13 2019 +0000" }, "message": "Use correct layer default configuration\n\nThe default layer configuration is contained in the `OCProperties.D`\ndictionary. Under certain circumstances, one of the configurations in\n`Configs` should be used.\n\nThe code was looking for the first config entry with the `Intent` set\nto `View` and also specifying the default value of `View`. This means\nthe first configuration entry that didn\u0027t have an `Intent` set was\nused, which is wrong. The `Intent` is optional. By removing the default\nvalue, we get the correct behavior.\n\nThe test checks that the correct layer configuration, `D`, is used by\nmaking sure the correct image is rendered.\n\nBug: pdfium:1283\n\nChange-Id: Icac852605e001151cec9cbefec17d06bf93f6e93\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/53370\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "bea47b2f16eb634b8b08e20948ec4e2588adee4f", "old_mode": 33188, "old_path": "AUTHORS", "new_id": "8fe2b46c2fa45f299a1b5a81ec4ade037bf00370", "new_mode": 33188, "new_path": "AUTHORS" }, { "type": "modify", "old_id": "e80907c3bb36af1e42e06365ba2bf4443ce02d20", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_occontext.cpp", "new_id": "8613bdd6daa2bd0e9bcaf5c3e92660270d5d31fa", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_occontext.cpp" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "2120f8666635004e00311ba1d840aa403d018ced", "new_mode": 33188, "new_path": "testing/resources/pixel/bug_1283.in" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "76369d68e8ddac07e5a9caf80b7dd64b85981b00", "new_mode": 33188, "new_path": "testing/resources/pixel/bug_1283_expected.pdf.0.png" } ] }