tree 2bb573a907c2977e7dcff6d160dc7330d441c3bb
parent 3dd6ef0648987f3c0b4b74aada0406a90e7947bd
author Tom Sepez <tsepez@chromium.org> 1562193534 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1562193534 +0000

Make CPDF_Color saner.

Stop casting a vector of floats to a PatternValue object type. Stop
performing cleanup for said PatternValue outside of the class itself.
Use std::vector in place of mallocs.

In turn, this requires making CPDF_Pattern and its subclasses
retainable, so that the cleanups happen automatically, which is
more straightforward than trying to move the old cleanup logic
into the PatternValue dtor.

In turn, make the doc page data weakly cache the CPDF_Patterns by
using the Observable pattern.

Change-Id: Idd1095cee3bd497392ea1f120bd452f3f34ce104
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/56750
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>