tree d1fa7eb98c8b622d86c0aa0b7e15a18ea3acb6c9
parent 73bd37c824051aac631abaf567bab7dcd02093df
author Lei Zhang <thestig@chromium.org> 1562279239 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1562279239 +0000

Revert "Make CPDF_Color saner."

This reverts commit 73bd37c824051aac631abaf567bab7dcd02093df.

Reason for revert: Made ClusterFuzz unhappy.

Original change's description:
> Make CPDF_Color saner.
> 
> Stop casting a vector of floats to a PatternValue object type. Stop
> performing cleanup for said PatternValue outside of the class itself.
> Use std::vector in place of mallocs.
> 
> In turn, this requires making CPDF_Pattern and its subclasses
> retainable, so that the cleanups happen automatically, which is
> more straightforward than trying to move the old cleanup logic
> into the PatternValue dtor.
> 
> In turn, make the doc page data weakly cache the CPDF_Patterns by
> using the Observable pattern.
> 
> Change-Id: Idd1095cee3bd497392ea1f120bd452f3f34ce104
> Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/56750
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>

TBR=thestig@chromium.org,tsepez@chromium.org

Change-Id: Ia25d36b47dc283469e7756e8573849ec69892189
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:981256,chromium:981288,chromium:981347,chromium:981412
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57330
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>