commit 5dccce5c7da8e966ab8d8ce7059ab5ca4a008db6
author Lei Zhang <thestig@chromium.org> Sat Nov 16 00:52:18 2019 +0000
committer Lei Zhang <thestig@chromium.org> Sat Nov 16 00:52:18 2019 +0000
tree b09971a042ca9b1ffae0c4f66a25f5d9cabab5f3
parent bbb4741901fe921324bfe5a36405291c58fd3162

M79: Use unsigned indices in sha1 computations.

Bug: chromium:1020899
Change-Id: Ieaf0636ba3d03334d780e4a40a02bc680bba9f18
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/61892
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
(cherry picked from commit da23189a76d224332c4fb71b1bba396c7d0a6817)
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62471

core/fdrm/fx_crypt.h

diff --git a/core/fdrm/fx_crypt.h b/core/fdrm/fx_crypt.h
index aab80df..6a1b976 100644
--- a/core/fdrm/fx_crypt.h
+++ b/core/fdrm/fx_crypt.h
@@ -35,11 +35,11 @@
 };
 
 struct CRYPT_sha1_context {
-  unsigned int h[5];
-  unsigned char block[64];
-  int blkused;
-  unsigned int lenhi;
-  unsigned int lenlo;
+  uint32_t h[5];
+  uint8_t block[64];
+  uint32_t blkused;  // Constrained to [0, 64).
+  uint32_t lenhi;
+  uint32_t lenlo;
 };
 
 struct CRYPT_sha2_context {

core/fdrm/fx_crypt_sha.cpp

diff --git a/core/fdrm/fx_crypt_sha.cpp b/core/fdrm/fx_crypt_sha.cpp
index 072b30d..afda87d 100644
--- a/core/fdrm/fx_crypt_sha.cpp
+++ b/core/fdrm/fx_crypt_sha.cpp
@@ -370,47 +370,41 @@
 void CRYPT_SHA1Update(CRYPT_sha1_context* context,
                       const uint8_t* data,
                       uint32_t size) {
-  unsigned char* q = (unsigned char*)data;
-  unsigned int wordblock[16];
-  int len = size;
-  unsigned int lenw = len;
-  int i;
-  context->lenlo += lenw;
-  context->lenhi += (context->lenlo < lenw);
-  if (context->blkused && context->blkused + len < 64) {
-    memcpy(context->block + context->blkused, q, len);
-    context->blkused += len;
-  } else {
-    while (context->blkused + len >= 64) {
-      memcpy(context->block + context->blkused, q, 64 - context->blkused);
-      q += 64 - context->blkused;
-      len -= 64 - context->blkused;
-      for (i = 0; i < 16; i++) {
-        wordblock[i] = (((unsigned int)context->block[i * 4 + 0]) << 24) |
-                       (((unsigned int)context->block[i * 4 + 1]) << 16) |
-                       (((unsigned int)context->block[i * 4 + 2]) << 8) |
-                       (((unsigned int)context->block[i * 4 + 3]) << 0);
-      }
-      SHATransform(context->h, wordblock);
-      context->blkused = 0;
-    }
-    memcpy(context->block, q, len);
-    context->blkused = len;
+  context->lenlo += size;
+  context->lenhi += (context->lenlo < size);  // Unsigned, so well-defined.
+  if (context->blkused && size < 64 - context->blkused) {
+    memcpy(context->block + context->blkused, data, size);
+    context->blkused += size;
+    return;
   }
+  uint32_t wordblock[16];
+  while (size >= 64 - context->blkused) {
+    memcpy(context->block + context->blkused, data, 64 - context->blkused);
+    data += 64 - context->blkused;
+    size -= 64 - context->blkused;
+    for (int i = 0; i < 16; i++) {
+      wordblock[i] = (((uint32_t)context->block[i * 4 + 0]) << 24) |
+                     (((uint32_t)context->block[i * 4 + 1]) << 16) |
+                     (((uint32_t)context->block[i * 4 + 2]) << 8) |
+                     (((uint32_t)context->block[i * 4 + 3]) << 0);
+    }
+    SHATransform(context->h, wordblock);
+    context->blkused = 0;
+  }
+  memcpy(context->block, data, size);
+  context->blkused = size;
 }
 
 void CRYPT_SHA1Finish(CRYPT_sha1_context* context, uint8_t digest[20]) {
-  int i;
-  int pad;
-  unsigned char c[64];
-  unsigned int lenhi, lenlo;
+  uint32_t lenhi = (context->lenhi << 3) | (context->lenlo >> (32 - 3));
+  uint32_t lenlo = (context->lenlo << 3);
+  uint8_t c[64];
+  uint8_t pad;
   if (context->blkused >= 56) {
     pad = 56 + 64 - context->blkused;
   } else {
     pad = 56 - context->blkused;
   }
-  lenhi = (context->lenhi << 3) | (context->lenlo >> (32 - 3));
-  lenlo = (context->lenlo << 3);
   memset(c, 0, pad);
   c[0] = 0x80;
   CRYPT_SHA1Update(context, c, pad);
@@ -423,7 +417,7 @@
   c[6] = (lenlo >> 8) & 0xFF;
   c[7] = (lenlo >> 0) & 0xFF;
   CRYPT_SHA1Update(context, c, 8);
-  for (i = 0; i < 5; i++) {
+  for (int i = 0; i < 5; i++) {
     digest[i * 4] = (context->h[i] >> 24) & 0xFF;
     digest[i * 4 + 1] = (context->h[i] >> 16) & 0xFF;
     digest[i * 4 + 2] = (context->h[i] >> 8) & 0xFF;