)]}' { "commit": "e87972e30da4cb87f0620baf32cea698f43dd093", "tree": "a6ee2dc024e2b0208549ca8207eca0c3095623a2", "parents": [ "26b030de1b76577df2b5af6d9a390ac7b292ba68" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Fri Nov 22 18:01:32 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 22 18:01:32 2019 +0000" }, "message": "Fix downcast in CXFA_FFTextEdit.\n\nThe |ff_widget_type_| of a CXFA_Node may reflect the type of its\nUI child node if it is of widget type |kNone|, so even if it claims\nto be of a particular type, it is only safe to downcast its UI\nchild to that particular type.\n\nBug: chromium:1026918\nChange-Id: I5daef3c6436ada6d31126ddb380f6420651b47e5\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62670\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "3a16c1490561814999b1288161667ea8fcd98cc3", "new_mode": 33188, "new_path": "testing/resources/pixel/xfa_specific/bug_1026918.evt" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "3dee61e00986140dd05db6cdecfedc4653fe8182", "new_mode": 33188, "new_path": "testing/resources/pixel/xfa_specific/bug_1026918.in" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "08c11b081166f82aacae6c5df0f05ed7c13b966a", "new_mode": 33188, "new_path": "testing/resources/pixel/xfa_specific/bug_1026918_expected.pdf.0.png" }, { "type": "modify", "old_id": "f5282ba840e0630155b47a9f4f1ad479efc972b0", "old_mode": 33188, "old_path": "xfa/fxfa/cxfa_fftextedit.cpp", "new_id": "5ac9f571c25bd97247287dadc67aa1319dffe28b", "new_mode": 33188, "new_path": "xfa/fxfa/cxfa_fftextedit.cpp" }, { "type": "modify", "old_id": "057c26ade1c740decef66132d20552f21819eb21", "old_mode": 33188, "old_path": "xfa/fxfa/parser/cxfa_node.h", "new_id": "9d9aec53ab2d34dc12f18c665daf001f4db2f0e6", "new_mode": 33188, "new_path": "xfa/fxfa/parser/cxfa_node.h" } ] }