commit a0a028072750e4734c1fdb3c2f23de8c20988c21
author Tom Sepez <tsepez@chromium.org> Thu Dec 12 21:18:43 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Dec 12 21:18:43 2019 +0000
tree 64758ed3d384d4e03f801e01cc8d97c94464e28d
parent 3d2c424ee2f121576198b23cdbdf8c952c4eb1af

Remove some comparisons against |true| and |false|.

Small code cleanup. No functional change intended.

Change-Id: Icc4476f4d04307dc43d546a97ec4e4ffb00a9a11
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63692
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

core/fxcodec/jbig2/JBig2_Context.cpp

diff --git a/core/fxcodec/jbig2/JBig2_Context.cpp b/core/fxcodec/jbig2/JBig2_Context.cpp
index 0bfdb7a..d9c9ee8 100644
--- a/core/fxcodec/jbig2/JBig2_Context.cpp
+++ b/core/fxcodec/jbig2/JBig2_Context.cpp
@@ -331,7 +331,7 @@
       pPageInfo->m_bIsStriped = !!(wTemp & 0x8000);
       pPageInfo->m_wMaxStripeSize = wTemp & 0x7fff;
       bool bMaxHeight = (pPageInfo->m_dwHeight == 0xffffffff);
-      if (bMaxHeight && pPageInfo->m_bIsStriped != true)
+      if (bMaxHeight && !pPageInfo->m_bIsStriped)
         pPageInfo->m_bIsStriped = true;
 
       if (!m_bBufSpecified) {

xfa/fxfa/cxfa_textlayout.cpp

diff --git a/xfa/fxfa/cxfa_textlayout.cpp b/xfa/fxfa/cxfa_textlayout.cpp
index d118882..7f6b328 100644
--- a/xfa/fxfa/cxfa_textlayout.cpp
+++ b/xfa/fxfa/cxfa_textlayout.cpp
@@ -728,7 +728,7 @@
         bIsOl = true;
         bCurOl = true;
       }
-      if (m_bBlockContinue || bContentNode == false) {
+      if (m_bBlockContinue || !bContentNode) {
         eDisplay = pContext->GetDisplay();
         if (eDisplay != CFX_CSSDisplay::Block &&
             eDisplay != CFX_CSSDisplay::Inline &&

xfa/fxfa/layout/cxfa_contentlayoutprocessor.cpp

diff --git a/xfa/fxfa/layout/cxfa_contentlayoutprocessor.cpp b/xfa/fxfa/layout/cxfa_contentlayoutprocessor.cpp
index 926436a..7b62264 100644
--- a/xfa/fxfa/layout/cxfa_contentlayoutprocessor.cpp
+++ b/xfa/fxfa/layout/cxfa_contentlayoutprocessor.cpp
@@ -2361,7 +2361,7 @@
     eRetValue = pProcessor->m_ePreProcessRs;
     pProcessor->m_ePreProcessRs = Result::kDone;
   }
-  if (pProcessor->HasLayoutItem() == false)
+  if (!pProcessor->HasLayoutItem())
     return eRetValue;
 
   CFX_SizeF childSize = pProcessor->GetCurrentComponentSize();

xfa/fxfa/parser/cxfa_document.cpp

diff --git a/xfa/fxfa/parser/cxfa_document.cpp b/xfa/fxfa/parser/cxfa_document.cpp
index 4212c1a..c341a69 100644
--- a/xfa/fxfa/parser/cxfa_document.cpp
+++ b/xfa/fxfa/parser/cxfa_document.cpp
@@ -1035,7 +1035,7 @@
       }
     }
 
-    if (iCurRepeatIndex == 0 && bAccessedDataDOM == false) {
+    if (iCurRepeatIndex == 0 && !bAccessedDataDOM) {
       int32_t iLimit = iMax;
       if (pInstMgrNode && pTemplateNode->GetNameHash() == 0) {
         iLimit = pdfium::CollectionSize<int32_t>(subformArray);

xfa/fxfa/parser/cxfa_localevalue.cpp

diff --git a/xfa/fxfa/parser/cxfa_localevalue.cpp b/xfa/fxfa/parser/cxfa_localevalue.cpp
index 32c642f..859e933 100644
--- a/xfa/fxfa/parser/cxfa_localevalue.cpp
+++ b/xfa/fxfa/parser/cxfa_localevalue.cpp
@@ -675,7 +675,7 @@
   int32_t nCountFmt = wsFormat.GetLength();
   while (n < nCount && (!bLimit || nf < nCountFmt) &&
          FXSYS_IsDecimalDigit(c = spNum[n])) {
-    if (bLimit == true) {
+    if (bLimit) {
       if ((cf = spFmt[nf]) == L'*')
         bLimit = false;
       else if (cf == L'z')