tree 10d687b01e8b52239bfd4b068dc73396a8f698bb
parent a4aee3e9c6f4fb1c3f561beaf7d744bfb16efbad
author Daniel Hosseinian <dhoss@chromium.org> 1579214717 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1579214717 +0000

Add nullptr checks prior to accesses of CPDF_Document::GetDocExtension()

Currently the CPDFXFA_Context creation occurs in LoadDocumentImpl()
regardless of whether --disable-xfa has been passed to pdfium_test.
In a future CL, we want to defer the context creation to
FPDFDOC_InitFormFillEnvironment() and make it conditional to whether the
runtime flag has been passed. However, certain parts of the code inside
PDF_ENABLE_XFA ifdefs always assume that the context exists and perform
no nullptr checks prior to accessing.

Along the way, fix a typo and change some unclear instances of auto
types to explicit types.

Bug: pdfium:1433
Change-Id: Ib1d63587ea6fc62d66cd933321c36182c3a21f42
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/64750
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>