tree 273edfff7a767f797e2a9f09e21f2fcb3c8d0a69
parent 38871db0a6cc1f9ed8139375a6846381182c2db0
author Hui Yingst <nigi@chromium.org> 1582993448 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1582993448 +0000

Enable RenderManyRectanglesWithExternalMemory for SkiaPaths/Skia.

Enables test RenderManyRectanglesWithExternalMemory for Skia and
SkiaPaths modes by fixing the following issues:

1. Skia and SkiaPaths only support color types that BPP (bit per pixel)
   is 8 or 32. Skip the test for FPDFBitmap_BGR format, which has
   BBP = 24.

2. Skia/SkiaPaths supports 2 SkColorTypes for bitmap with BPP = 8,
   kAlpha_8_SkColorType and kGray_8_SkColorType. However, the rendering
   process only uses kAlpha_8_SkColorType as the color type for all
   BBP = 8 cases without checking whether the bitmap format is an alpha
   type, which leads to the blank rendering result for format
   FPDFBitmap_Gray. This CL adds the check for alpha type when choosing
   SkColorTypes during rendering.

3. Skia/SkiaPaths uses a different algorithm to render gradient effect
   compared to AGG. This CL adds the expected results for Skia and
   SkiaPaths modes.

Bug: pdfium:1488
Change-Id: I88dbf139e2c6fe33bde83efa51f2665f8525f6d1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67050
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>