)]}' { "commit": "b8b3f5ffc0ea33f06402e03145f26ed6d581b552", "tree": "40c9044a9ada01fe10ff58ebb07798ce7aa62f77", "parents": [ "c0d7928ef7b0ba4c6c993af979f206585ce8e011" ], "author": { "name": "Hui Yingst", "email": "nigi@chromium.org", "time": "Sat Apr 11 00:20:36 2020 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Sat Apr 11 00:20:36 2020 +0000" }, "message": "Update pixel/corpus tests to handle expected results for Skia.\n\nWith pdf_use_skia enabled, the rendering results can be correct but\nslightly different compared to AGG\u0027s results. This CL allows\nrun_pixel_tests.py and run_corpus_tests.py to also compared to\nacceptable rendering results generated by Skia, named in the format of\n\"NAME_expected_skia(_(win|mac|linux))?.pdf.#.png\". So that if the\nrendering result of a PDF is not completely the same as its AGG\u0027s\nexpectation, as long as it finds a match with a Skia expected rendering\nresult, it won\u0027t cause a failure in pixel/corpus test.\n\nThis CL also provides a PNG file of Skia-based expected result of pixel\ntest bug_842.in to test the script change. This pixel test contains a\ngradient transition that Skia uses a different algorithm to render\ncompared to AGG.\n\nIn case that SkiaPaths, Skia and AGG all generate correct results and\nthese results are different from each other, we will need to add\nexpected results for SkiaPaths in a new format of\n\"NAME_expected_skiapaths(_(win|mac|linux))?.pdf.#.png\", besides the\nexpected results of Skia and AGG. Currently we don\u0027t have an existing\ntest case that can be rendered differently and correctly among using\nall three rendering methods. Therefore there is no PNG file uploaded for\ntesting this SkiaPaths specific change.\n\nBug: pdfium:1501\nChange-Id: I237c70bdec2640995f9cb8602d0b32addc0598e0\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67871\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Hui Yingst \u003cnigi@chromium.org\u003e\n", "tree_diff": [ { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "b454aa53772d0d018bc82982f413a591ff974c54", "new_mode": 33188, "new_path": "testing/resources/pixel/bug_842_expected_skia.pdf.0.png" }, { "type": "modify", "old_id": "85179f8eb2701efbdd9b5c882f96de4c70b103f5", "old_mode": 33261, "old_path": "testing/tools/pngdiffer.py", "new_id": "63315c9038c09ff1aa73cb05c3fa0c9ccd70abfa", "new_mode": 33261, "new_path": "testing/tools/pngdiffer.py" }, { "type": "modify", "old_id": "363faf3d80e7da26f4dc005463a55fe67d3ec7cd", "old_mode": 33188, "old_path": "testing/tools/test_runner.py", "new_id": "f4b45ac6f0b5f47f32f1dcf5d116c59a35f18307", "new_mode": 33188, "new_path": "testing/tools/test_runner.py" } ] }