tree 40c9044a9ada01fe10ff58ebb07798ce7aa62f77
parent c0d7928ef7b0ba4c6c993af979f206585ce8e011
author Hui Yingst <nigi@chromium.org> 1586564436 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1586564436 +0000

Update pixel/corpus tests to handle expected results for Skia.

With pdf_use_skia enabled, the rendering results can be correct but
slightly different compared to AGG's results. This CL allows
run_pixel_tests.py and run_corpus_tests.py to also compared to
acceptable rendering results generated by Skia, named in the format of
"NAME_expected_skia(_(win|mac|linux))?.pdf.#.png". So that if the
rendering result of a PDF is not completely the same as its AGG's
expectation, as long as it finds a match with a Skia expected rendering
result, it won't cause a failure in pixel/corpus test.

This CL also provides a PNG file of Skia-based expected result of pixel
test bug_842.in to test the script change. This pixel test contains a
gradient transition that Skia uses a different algorithm to render
compared to AGG.

In case that SkiaPaths, Skia and AGG all generate correct results and
these results are different from each other, we will need to add
expected results for SkiaPaths in a new format of
"NAME_expected_skiapaths(_(win|mac|linux))?.pdf.#.png", besides the
expected results of Skia and AGG. Currently we don't have an existing
test case that can be rendered differently and correctly among using
all three rendering methods. Therefore there is no PNG file uploaded for
testing this SkiaPaths specific change.

Bug: pdfium:1501
Change-Id: I237c70bdec2640995f9cb8602d0b32addc0598e0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67871
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>