)]}' { "commit": "634973155ab5f27f443c38292efca94647bff5f9", "tree": "ed74395c92f3bb195d1c74c1c6d95cb3f7fcf1cf", "parents": [ "4f33e7314cdcf3f05f8a2d5d4b70c01e0e44d05f" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Jun 02 01:09:29 2020 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Tue Jun 02 01:09:29 2020 +0000" }, "message": "Use more RetainPtrs in CXFA_FFTabOrderPageWidgetIterator.\n\n- Make CreateSpaceOrderLayoutItems() return a vector of\n RetainPtr\u003cCXFA_ContentLayoutItem\u003e instead of CXFA_FFWidget pointers.\n- Change CreateTabOrderWidgetArray() to use the RetainPtrs.\n- Add a test for this case.\n\nBug: chromium:980116\nChange-Id: I5ef172930e775a07fb37e2dffe2318ead76961cb\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70213\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "a5025fa1319f4baec4f1f3b69c32989025bf12fc", "new_mode": 33188, "new_path": "testing/resources/javascript/xfa_specific/bug_980116.evt" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "11bcbf2740191216925d5efc767c90b1bbf9807e", "new_mode": 33188, "new_path": "testing/resources/javascript/xfa_specific/bug_980116.in" }, { "type": "modify", "old_id": "6ff6ee81f5c8410afdb53760649bda03e8506825", "old_mode": 33188, "old_path": "xfa/fxfa/cxfa_ffpageview.cpp", "new_id": "996d8e51e4fcc2ed8626cbd5c5a91b80da7404b3", "new_mode": 33188, "new_path": "xfa/fxfa/cxfa_ffpageview.cpp" }, { "type": "modify", "old_id": "5599af0947f3561f0ae753d30836ae3a67dec931", "old_mode": 33188, "old_path": "xfa/fxfa/cxfa_ffpageview.h", "new_id": "ad0ff26cf28b7fe9e30e69bdbd1d34a6b93ea2b6", "new_mode": 33188, "new_path": "xfa/fxfa/cxfa_ffpageview.h" } ] }