commit bd9fea3cfc8e3420bc9f5e0b1c84fde0c55df7f1
author Hui Yingst <nigi@chromium.org> Thu Jul 30 22:42:52 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Jul 30 22:42:52 2020 +0000
tree 2b0b80020937b13f27274c122a92c4c32a000cef
parent 9d8e5ec1ac15edb77142be91c3d8fc7d36079b97

Add a test of rendering with no flags in FPDFViewEmbedderTest.RenderBug664284WithNoNativeText.

To demonstrate that flag FPDF_NO_NATIVETEXT only has impact on macOS,
this CL adds an additional test for rendering bug_664284.pdf with no
flags for comparing the rendering result changes on different platforms.

Change-Id: I0026951ad557881aab3544a9f7a0bf7e247ddac3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/72235
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

fpdfsdk/fpdf_view_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_view_embeddertest.cpp b/fpdfsdk/fpdf_view_embeddertest.cpp
index b13efa0..a3ba17d 100644
--- a/fpdfsdk/fpdf_view_embeddertest.cpp
+++ b/fpdfsdk/fpdf_view_embeddertest.cpp
@@ -1235,14 +1235,19 @@
 }
 
 TEST_F(FPDFViewEmbedderTest, RenderBug664284WithNoNativeText) {
-// FPDF_NO_NATIVETEXT flag disables native text support on macOS, therefore
+// FPDF_NO_NATIVETEXT flag only disables native text support on macOS, therefore
 // Windows and Linux rendering results remain the same as rendering with no
-// flag, while the expected hash value for macOS rendering result is no longer
-// "41ada106c6133b52ea45280eaaa38ae1"(hash value for rendering with no flag).
+// flags, while the macOS rendering result doesn't.
 #if defined(OS_WIN)
+  static const char kOriginalChecksum[] = "4671643caf99a1f4b6c0117ccb7bc9e7";
   static const char kNoNativeTextChecksum[] =
       "4671643caf99a1f4b6c0117ccb7bc9e7";
+#elif defined(OS_APPLE)
+  static const char kOriginalChecksum[] = "41ada106c6133b52ea45280eaaa38ae1";
+  static const char kNoNativeTextChecksum[] =
+      "d64d6b0fc39a8cefc43de39da5c60b17";
 #else
+  static const char kOriginalChecksum[] = "d64d6b0fc39a8cefc43de39da5c60b17";
   static const char kNoNativeTextChecksum[] =
       "d64d6b0fc39a8cefc43de39da5c60b17";
 #endif
@@ -1251,6 +1256,7 @@
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
 
+  TestRenderPageBitmapWithFlags(page, 0, kOriginalChecksum);
   TestRenderPageBitmapWithFlags(page, FPDF_NO_NATIVETEXT,
                                 kNoNativeTextChecksum);