Enable FPDFEditEmbedderTest.AddPaths for Skia/SkiaPaths.
When rendering a Bezier curve whose start point, end point and the
control points are all on the same straight line, Skia/SkiaPaths renders
it as a almost straight line while AGG doesn't render it at all. Since
Skia/SkiaPaths shows improved rendering results compare to AGG, enable
FPDFEditEmbedderTest.AddPaths to increase test coverage.
The AGG and Skia/SkiaPaths rendering results are uploaded at [1].
[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=1500#c91
Bug: pdfium:1500
Change-Id: I4e792d89c2730a77c6fcded9780359a5c92694e6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/77171
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>
diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index e64c0b3..bb8e8e5 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -349,13 +349,7 @@
VerifySavedDocument(612, 792, kAllBlackMd5sum);
}
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
-#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-#define MAYBE_AddPaths DISABLED_AddPaths
-#else
-#define MAYBE_AddPaths AddPaths
-#endif
-TEST_F(FPDFEditEmbedderTest, MAYBE_AddPaths) {
+TEST_F(FPDFEditEmbedderTest, AddPaths) {
// Start with a blank page
FPDF_PAGE page = FPDFPage_New(CreateNewDocument(), 0, 612, 792);
ASSERT_TRUE(page);
@@ -515,10 +509,14 @@
EXPECT_TRUE(FPDFPath_BezierTo(blue_path, 375, 330, 390, 360, 400, 400));
EXPECT_TRUE(FPDFPath_Close(blue_path));
FPDFPage_InsertObject(page, blue_path);
- const char kLastMD5[] = "9823e1a21bd9b72b6a442ba4f12af946";
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+ static constexpr char kLastChecksum[] = "ed14c60702b1489c597c7d46ece7f86d";
+#else
+ static constexpr char kLastChecksum[] = "9823e1a21bd9b72b6a442ba4f12af946";
+#endif
{
ScopedFPDFBitmap page_bitmap = RenderPage(page);
- CompareBitmap(page_bitmap.get(), 612, 792, kLastMD5);
+ CompareBitmap(page_bitmap.get(), 612, 792, kLastChecksum);
}
// Now save the result, closing the page and document
@@ -527,7 +525,7 @@
FPDF_ClosePage(page);
// Render the saved result
- VerifySavedDocument(612, 792, kLastMD5);
+ VerifySavedDocument(612, 792, kLastChecksum);
}
TEST_F(FPDFEditEmbedderTest, ClipPath) {
