commit 041116eb9e8da9563940379fa6ee7179107897bb
author Hui Yingst <nigi@chromium.org> Mon Mar 01 21:27:50 2021 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Mar 01 21:27:50 2021 +0000
tree 861331d35e3d79c72e9b2d1bad04f8b3aa4b6731
parent a929df78632d703d9a9fca8fb946f6778c49703d

Enable FPDFEditEmbedderTest.AddStrokedPaths for SkiaPaths.

For FPDFEditEmbedderTest.AddStrokedPaths, AGG and Skia/SkiaPaths
rendering results have been uploaded to [1]. We can tell that all 3
rendering results from SkiaPaths are acceptable compared to AGG, while
Skia fails to render the 3rd bitmap (The stroke and fill color overlap
with each other.).

Therefore only enable this embedder test for SkiaPaths and file [2] for
the Skia rendering problem.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=1500#c93
[2] https://crbug.com/pdfium/1651

Bug: pdfium:1500
Change-Id: I47e23e6f66c11882884f0242fc48fd50140bf6a4
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/78250
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

fpdfsdk/fpdf_edit_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index bb8e8e5..15f5f28 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -2107,8 +2107,8 @@
   VerifySavedDocument(612, 792, kLastChecksum);
 }
 
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
-#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+// TODO(crbug.com/pdfium/1651): Fix this issue and enable the test for Skia.
+#if defined(_SKIA_SUPPORT_)
 #define MAYBE_AddStrokedPaths DISABLED_AddStrokedPaths
 #else
 #define MAYBE_AddStrokedPaths AddStrokedPaths
@@ -2131,8 +2131,12 @@
   FPDFPage_InsertObject(page, rect);
   {
     ScopedFPDFBitmap page_bitmap = RenderPage(page);
-    CompareBitmap(page_bitmap.get(), 612, 792,
-                  "64bd31f862a89e0a9e505a5af6efd506");
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+    static constexpr char kChecksum_1[] = "1469acf60e7647ebeb8e1fb08c5d6c7a";
+#else
+    static constexpr char kChecksum_1[] = "64bd31f862a89e0a9e505a5af6efd506";
+#endif
+    CompareBitmap(page_bitmap.get(), 612, 792, kChecksum_1);
   }
 
   // Add crossed-checkmark
@@ -2147,8 +2151,12 @@
   FPDFPage_InsertObject(page, check);
   {
     ScopedFPDFBitmap page_bitmap = RenderPage(page);
-    CompareBitmap(page_bitmap.get(), 612, 792,
-                  "4b6f3b9d25c4e194821217d5016c3724");
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+    static constexpr char kChecksum_2[] = "68b3194f74abd9d471695ce1415be43f";
+#else
+    static constexpr char kChecksum_2[] = "4b6f3b9d25c4e194821217d5016c3724";
+#endif
+    CompareBitmap(page_bitmap.get(), 612, 792, kChecksum_2);
   }
 
   // Add stroked and filled oval-ish path.
@@ -2164,8 +2172,12 @@
   FPDFPage_InsertObject(page, path);
   {
     ScopedFPDFBitmap page_bitmap = RenderPage(page);
-    CompareBitmap(page_bitmap.get(), 612, 792,
-                  "ff3e6a22326754944cc6e56609acd73b");
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+    static constexpr char kChecksum_3[] = "ea784068651df2b9ba132ce9215e6780";
+#else
+    static constexpr char kChecksum_3[] = "ff3e6a22326754944cc6e56609acd73b";
+#endif
+    CompareBitmap(page_bitmap.get(), 612, 792, kChecksum_3);
   }
   FPDF_ClosePage(page);
 }