tree 9e6c85cf2518e131c1c8b2cc4e05cafe03268fce
parent 79bc107ea7bb32098b8e2a4fa4b307fcd6e463ce
author Tom Sepez <tsepez@chromium.org> 1616523574 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1616523574 +0000

Avoid unique_ptrs to string streams in CPDF_PageContentGenerator.

Move-assignment of a string stream should be a reasonably efficient
no-copy operation, so the additional indirection through the unique_ptr
isn't needed.

The only complication is we hit a "const" issue in one place, so
convert one method to take an rvalue reference from its only caller
to avoid passing args by non-const ref (and avoid unintended copies).

Change-Id: Ie7b8aa1a2b1a864521faa30ebcb2343861064620
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/78713
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>