commit 912235c7999cc8e96747c085988af7dee88330a4
author Lei Zhang <thestig@chromium.org> Sat Apr 24 04:05:41 2021 +0000
committer Chromium commit bot <commit-bot@chromium.org> Sat Apr 24 04:05:41 2021 +0000
tree 14afbe143a5786ae11cfe90bab0e4abdcd406cff
parent 34ee5dbb860ef822d00aa3e78499acc097dc4d0c

Use operator!= instead of Compare().

Replace str.Compare(foo) != 0 with str != foo.

Change-Id: I33906ae48457d3d1c948f44b22e743aac36a107d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79875
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/cpdfsdk_interactiveform.cpp

diff --git a/fpdfsdk/cpdfsdk_interactiveform.cpp b/fpdfsdk/cpdfsdk_interactiveform.cpp
index d6d23b1..3ed3a7d 100644
--- a/fpdfsdk/cpdfsdk_interactiveform.cpp
+++ b/fpdfsdk/cpdfsdk_interactiveform.cpp
@@ -280,7 +280,7 @@
     pContext->OnField_Calculate(pFormField, pField, &sValue, &bRC);
 
     Optional<IJS_Runtime::JS_Error> err = pContext->RunScript(csJS);
-    if (!err && bRC && sValue.Compare(sOldValue) != 0)
+    if (!err && bRC && sValue != sOldValue)
       pField->SetValue(sValue, NotificationOption::kNotify);
   }
 }

fxjs/cjs_field.cpp

diff --git a/fxjs/cjs_field.cpp b/fxjs/cjs_field.cpp
index 35ff13b..abe8403 100644
--- a/fxjs/cjs_field.cpp
+++ b/fxjs/cjs_field.cpp
@@ -451,7 +451,7 @@
       GetFormFieldsForName(pFormFillEnv, swFieldName);
 
   for (CPDF_FormField* pFormField : FieldArray) {
-    if (pFormField->GetFullName().Compare(swFieldName) != 0)
+    if (pFormField->GetFullName() != swFieldName)
       continue;
 
     switch (pFormField->GetFieldType()) {