)]}' { "commit": "6c57cda7d994b2eb69b598f0b25a6359433e7ab8", "tree": "a6372045c1686e1a639a874fa9a913bb6b5069ce", "parents": [ "2f36f88109e0b8e39b1faf6b70708d1ac2beb5b7" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Fri Jul 23 19:41:57 2021 +0000" }, "committer": { "name": "Pdfium LUCI CQ", "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 23 19:41:57 2021 +0000" }, "message": "Make FX_CodePage an enum class.\n\nReplaces using a number of FX_CODEPAGE_ #defines. In turn, move\nsome functions that require FX_CodePage arguments from fx_system.h\nto fx_codepage.h.\n\n-- Introduce new kFailure sentinel.\n-- Introduce incomplete definition header fx_codepage_forward.h\n-- Replace literal integers with symbolic names where needed.\n-- Correct \"847\" to Thai (874).\n\n\nChange-Id: I1a74672c1c42855a0bd4716f6d33ef3c57f08e5c\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83290\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "d8b7b149884413ed90cff58bd2044e332879459f", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_cidfont.cpp", "new_id": "071779542e99147bffa2eaecf90dcc5b16ff122c", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_cidfont.cpp" }, { "type": "modify", "old_id": "11f6d81fefac4b3b9e337d22b76a2365a580198e", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_cidfont.h", "new_id": "bf07aa6de662ed47291d9bd2f4c43052c1d254a2", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_cidfont.h" }, { "type": "modify", "old_id": "d85eff20bc0acb2e25173dce5d777ed2d3b2b153", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_font.cpp", "new_id": "1391f5ac4e6dda447fe72c8d754d3c0c6065e0ca", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_font.cpp" }, { "type": "modify", "old_id": "698e35ba0cae2de50cda63c88eb6d1694f43fac8", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_simplefont.cpp", "new_id": "15936396164f600461393276d57b929fee8fac08", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_simplefont.cpp" }, { "type": "modify", "old_id": "ab92dc94935b76ca0ba4a20624f3ee015b54bbd5", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_bafontmap.cpp", "new_id": "174e937c4148bd7090e8ee6d06c4d1f2ce5d6569", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_bafontmap.cpp" }, { "type": "modify", "old_id": "5f4e605fc7a609e705b86d6152b7da0bf0c11f04", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_interactiveform.cpp", "new_id": "8c6e89b008bcc70da2c2fde567bf08d0aa798b7a", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_interactiveform.cpp" }, { "type": "modify", "old_id": "07beba693cf50c6c2724137e0fa8f27c12dbc4a0", "old_mode": 33188, "old_path": "core/fxcrt/BUILD.gn", "new_id": "8509148b6dcc97b1347935a5b82660eb6d75aecd", "new_mode": 33188, "new_path": "core/fxcrt/BUILD.gn" }, { "type": "modify", "old_id": "f677eec97ccdb19cb434616203c5a2890fa5fbd8", "old_mode": 33188, "old_path": "core/fxcrt/cfx_seekablestreamproxy.cpp", "new_id": "666aee55e755c11e6a8f974c8d1f59babb102579", "new_mode": 33188, "new_path": "core/fxcrt/cfx_seekablestreamproxy.cpp" }, { "type": "modify", "old_id": "bfff049cdc11117022d693fe2a680ed95c225f8d", "old_mode": 33188, "old_path": "core/fxcrt/cfx_seekablestreamproxy.h", "new_id": "587a570396ecef643845874e914a573dc39deb22", "new_mode": 33188, "new_path": "core/fxcrt/cfx_seekablestreamproxy.h" }, { "type": "modify", "old_id": "c85291fe4e27a20a4ee0432c6d9940e4615ec8e5", "old_mode": 33188, "old_path": "core/fxcrt/fx_codepage.cpp", "new_id": "993853b0d168c77571548b91a2f2b600352ec546", "new_mode": 33188, "new_path": "core/fxcrt/fx_codepage.cpp" }, { "type": "modify", "old_id": "935425d5f0fdb642f494c73a67e3fc01fc2ae722", "old_mode": 33188, "old_path": "core/fxcrt/fx_codepage.h", "new_id": "ae4ecf09f3050f0f601a78d7035c53885e457e41", "new_mode": 33188, "new_path": "core/fxcrt/fx_codepage.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "e941d0a52487e9c9e67844797dad53a78ffd23a1", "new_mode": 33188, "new_path": "core/fxcrt/fx_codepage_forward.h" }, { "type": "modify", "old_id": "52da8e0bf9edf3497291bd90e66ea1783cf42168", "old_mode": 33188, "old_path": "core/fxcrt/fx_system.cpp", "new_id": "47d2db9a0fb10e09ad8bf375e8de3071b7e4d374", "new_mode": 33188, "new_path": "core/fxcrt/fx_system.cpp" }, { "type": "modify", "old_id": "29b3c5637ae491668c0c1e5204321212346d9af4", "old_mode": 33188, "old_path": "core/fxcrt/fx_system.h", "new_id": "beb1d7ee6097266632aca2c506a0371213bb99a4", "new_mode": 33188, "new_path": "core/fxcrt/fx_system.h" }, { "type": "modify", "old_id": "6ae40a94c637c6f9b5da78e4a6eff1b20f90eb48", "old_mode": 33188, "old_path": "core/fxcrt/widestring.cpp", "new_id": "c3ec07fcacb3b8c214dd5a48fe2792076b0b9ae7", "new_mode": 33188, "new_path": "core/fxcrt/widestring.cpp" }, { "type": "modify", "old_id": "5f28388a23024a3687a27fca75fe55b5a8006dde", "old_mode": 33188, "old_path": "core/fxcrt/xml/cfx_xmlparser.cpp", "new_id": "9008e12985d2228c9e474c7505c1455bc48bb5bc", "new_mode": 33188, "new_path": "core/fxcrt/xml/cfx_xmlparser.cpp" }, { "type": "modify", "old_id": "86b6cbe5e813b2963e08c8c31ad0468ca145eeb6", "old_mode": 33188, "old_path": "core/fxge/cfx_font.cpp", "new_id": "df2bab1f0570540ac51f3229f734b58936dbab42", "new_mode": 33188, "new_path": "core/fxge/cfx_font.cpp" }, { "type": "modify", "old_id": "f86bc73255451b22b3580ab9f4581f14a56c615b", "old_mode": 33188, "old_path": "core/fxge/cfx_font.h", "new_id": "57177e49a6ba2ca6390647207d40495fbfcdaa15", "new_mode": 33188, "new_path": "core/fxge/cfx_font.h" }, { "type": "modify", "old_id": "0a2247089810ae4963b8b054cfee9b960ba10a46", "old_mode": 33188, "old_path": "core/fxge/cfx_fontmapper.cpp", "new_id": "db28c209b9100f69808127f11d475fbe33db8f7b", "new_mode": 33188, "new_path": "core/fxge/cfx_fontmapper.cpp" }, { "type": "modify", "old_id": "e1897d4655144b0d54429daf4a97ba610c30c499", "old_mode": 33188, "old_path": "core/fxge/cfx_fontmapper.h", "new_id": "cd200c705b6ba76130ddc17c964b1b2b7df0c6d4", "new_mode": 33188, "new_path": "core/fxge/cfx_fontmapper.h" }, { "type": "modify", "old_id": "6cab19fc366fa337b96fd69ce2a50eb4014398a5", "old_mode": 33188, "old_path": "core/fxge/cfx_fontmgr.cpp", "new_id": "5e01413654e414c92b6b8ef7a080d082f0c4b813", "new_mode": 33188, "new_path": "core/fxge/cfx_fontmgr.cpp" }, { "type": "modify", "old_id": "1c4f68cb7ad032934ee7f821ae3fbe9a513239c2", "old_mode": 33188, "old_path": "core/fxge/cfx_fontmgr.h", "new_id": "5b99f415ad213982976ffac6502422eeca143b3e", "new_mode": 33188, "new_path": "core/fxge/cfx_fontmgr.h" }, { "type": "modify", "old_id": "97a52fdaa66a5872de70032c363a6a42aca1552d", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_edit_embeddertest.cpp", "new_id": "4ea5c14bb4a84d54fb03c66f7c467560d889c984", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_edit_embeddertest.cpp" }, { "type": "modify", "old_id": "1e4c08d52598d2e624060ad8363fbb4af43990a1", "old_mode": 33188, "old_path": "testing/fuzzers/pdf_bidi_fuzzer.cc", "new_id": "3c77b765ceab9cbeadab50f561774fc6479974f1", "new_mode": 33188, "new_path": "testing/fuzzers/pdf_bidi_fuzzer.cc" }, { "type": "modify", "old_id": "9dfd221c9445bcaeab8033260977856318bcd88d", "old_mode": 33188, "old_path": "xfa/fde/cfde_texteditengine_unittest.cpp", "new_id": "b532770b2690fccce39c9d792c0841c4c06e24fd", "new_mode": 33188, "new_path": "xfa/fde/cfde_texteditengine_unittest.cpp" }, { "type": "modify", "old_id": "c28b21bedfb2b3e8ac6c7b4ea7ef436e0ac7f7e5", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_defaultfontmanager.cpp", "new_id": "3f0bb244e083794d153ee54a5dd962843c98bd55", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_defaultfontmanager.cpp" }, { "type": "modify", "old_id": "91c2e99971a247b9dcf259e9438cb2e946605c11", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_fontmgr.cpp", "new_id": "6b2aef916c7555ffdb2a5a48c880f793ca701a06", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_fontmgr.cpp" }, { "type": "modify", "old_id": "6f4828b0c3aa57a561070d68f8ff1a601eda06a8", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_fontmgr.h", "new_id": "6e17c15dcbac9f886d5f4d82f498c367a5f56963", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_fontmgr.h" }, { "type": "modify", "old_id": "43f1fde93aef83754c6376cda36960556673e8fe", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_gefont.cpp", "new_id": "fcb304d857c0187ae393f2dcfd8b46fe4b4bd539", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_gefont.cpp" }, { "type": "modify", "old_id": "9716bf58a6570d14f9d70dda9a61b2ed678046a4", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_gefont.h", "new_id": "c29da21691e707e26836d713e9d56f89a250cf16", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_gefont.h" }, { "type": "modify", "old_id": "191aeb81db5452246e31a766dec449efd5c08a0c", "old_mode": 33188, "old_path": "xfa/fgas/font/fgas_fontutils.cpp", "new_id": "3bbe383ce8940891192b3c0e39c9e4f10b50df7a", "new_mode": 33188, "new_path": "xfa/fgas/font/fgas_fontutils.cpp" }, { "type": "modify", "old_id": "91998d523584fdcb13451fee8f5e27b66a10c99d", "old_mode": 33188, "old_path": "xfa/fgas/font/fgas_fontutils.h", "new_id": "055d0198385fbe08d165d4865dd5a385718396f7", "new_mode": 33188, "new_path": "xfa/fgas/font/fgas_fontutils.h" }, { "type": "modify", "old_id": "b424a49f27cbf96de4e783f693bccd046179a034", "old_mode": 33188, "old_path": "xfa/fgas/layout/cfgas_rtfbreak_unittest.cpp", "new_id": "42791469790fc49e19fc87f4fd4455105e0bf761", "new_mode": 33188, "new_path": "xfa/fgas/layout/cfgas_rtfbreak_unittest.cpp" }, { "type": "modify", "old_id": "54a452369a0160d17e46d6d5b0b9739abc7c4dd2", "old_mode": 33188, "old_path": "xfa/fgas/layout/cfgas_txtbreak.cpp", "new_id": "fc07ffcc93c59b7ee454bff38a0c72c2b0926ee1", "new_mode": 33188, "new_path": "xfa/fgas/layout/cfgas_txtbreak.cpp" }, { "type": "modify", "old_id": "4d64b9a3ada79c76b107cd7441a5429d26561ca5", "old_mode": 33188, "old_path": "xfa/fgas/layout/cfgas_txtbreak_unittest.cpp", "new_id": "743a9abd9062b0e2254e85006dc211f5be099086", "new_mode": 33188, "new_path": "xfa/fgas/layout/cfgas_txtbreak_unittest.cpp" }, { "type": "modify", "old_id": "30ece5403f6dc388ed8f397fbd03359c40527ca5", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_fontmanager.cpp", "new_id": "be7106bb5a6100bd56f261086698b18eeaf04408", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_fontmanager.cpp" }, { "type": "modify", "old_id": "6a80ea8f39651078b736e87f69f48f6dc2488402", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_fontmanager.h", "new_id": "3f950c63bd6e23511769c5f28cd69053221ecdac", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_fontmanager.h" }, { "type": "modify", "old_id": "e87fc3fac9e4fe06b3aed31f8395577f8449b654", "old_mode": 33188, "old_path": "xfa/fwl/theme/cfwl_widgettp.cpp", "new_id": "bbd2120005ef7b8a9aaf24756a4fa29ac39c4674", "new_mode": 33188, "new_path": "xfa/fwl/theme/cfwl_widgettp.cpp" }, { "type": "modify", "old_id": "ff0d3c1670965927de2a105d74b467c6769a9e38", "old_mode": 33188, "old_path": "xfa/fxfa/cxfa_fwltheme.cpp", "new_id": "1379f97ef4a3aae59a6cb96b3d5b0d104bb21d0f", "new_mode": 33188, "new_path": "xfa/fxfa/cxfa_fwltheme.cpp" } ] }