tree b4c8b97531c6a814a1ded44933f530fbe4aae7c3
parent fdf2c51e4ee41fadabd7035d474397d491463f0c
author Tom Sepez <tsepez@chromium.org> 1627518640 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1627518640 +0000

Consolidate CFLW_PartState to FWLTHEME_STATE conversions

This is currently being done in three different ways in three
different places in xfa/fwl. All of them appear wrong because
either:

-- PartState is a bitmap so switching on it is wrong.
-- &ing it with 0x03 doesn't select the bits we want to test.
-- &ing it against a different type is not meaningful.
-- Not all of the possibilities are covered sometimes.

Add a method GetThemeStates() that tests each bit in order of
some natural "priority".

-- Inline DrawDropDownButton() methods into only callers.

Change-Id: Iaef63405ed061212aff371dca0fe76001aec6a10
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83591
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>