tree 9fe1ea2e6e6e9b0c2272aa7a50daa3647dff91ae
parent 5ea38ddd227842532d448882b9937a147415733b
author Tom Sepez <tsepez@chromium.org> 1633976997 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1633976997 +0000

Revert "Use spancpy() in CFX_DIBBase::Clone()."

This reverts commit aa7822513967ba139ce9e9fdf10ea8e00b7a621c.

Reason for revert: https://crbug.com/1258634

Avoid a check while we diagnose what CPDF_DIB is doing when it
thinks there are only two components to an image.

Original change's description:
> Use spancpy() in CFX_DIBBase::Clone().
>
> Had Clone() been coded like this originally, even without the safe
> arithmetic, the issue in https://pdfium-review.googlesource.com/85510
> would have caused a trap. The additional checks should be acceptable
> since they occur once per scanline and not once per pixel.
>
> Change-Id: I0b0c8b0977e6902a4c233b582cbdb01796871174
> Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85555
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9e1ff0438b0d17e391f63c16a7d4b8a241b03b99
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85850
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>