commit 03c04196f4875d157901830aa3297dbe2dd77169
author Lei Zhang <thestig@chromium.org> Tue Oct 31 21:13:37 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Oct 31 21:13:37 2023 +0000
tree c635453f68af84b26f8e1943b41c0b1e99dab06d
parent fdb409aaf2dd5e5d49fc3dd326a80197fd2d667e

Remove unnecessary LoadLibrary() call in CGdiplusExt

CGdiplusExt loads gdi32.dll, but does not use it for anything. Remove
this code and the associated CGdiplusExt::m_GdiModule member variable.
https://pdfium-review.googlesource.com/44554 should have removed this.

Change-Id: I6720190df53d3bed984dc7cb89df054c87e31f37
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/113270
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fxge/win32/cgdi_plus_ext.cpp

diff --git a/core/fxge/win32/cgdi_plus_ext.cpp b/core/fxge/win32/cgdi_plus_ext.cpp
index 0cd0a37..3c33ea0 100644
--- a/core/fxge/win32/cgdi_plus_ext.cpp
+++ b/core/fxge/win32/cgdi_plus_ext.cpp
@@ -557,7 +557,6 @@
 CGdiplusExt::CGdiplusExt() = default;
 
 CGdiplusExt::~CGdiplusExt() {
-  FreeLibrary(m_GdiModule);
   FreeLibrary(m_hModule);
 }
 
@@ -583,7 +582,6 @@
   Gdiplus::GdiplusStartupInput gdiplus_startup_input;
   ((FuncType_GdiplusStartup)m_Functions[FuncId_GdiplusStartup])(
       &gdiplus_token, &gdiplus_startup_input, nullptr);
-  m_GdiModule = LoadLibraryA("GDI32.DLL");
 }
 
 bool CGdiplusExt::StretchDIBits(HDC hDC,

core/fxge/win32/cgdi_plus_ext.h

diff --git a/core/fxge/win32/cgdi_plus_ext.h b/core/fxge/win32/cgdi_plus_ext.h
index ced36c9..e6a1363 100644
--- a/core/fxge/win32/cgdi_plus_ext.h
+++ b/core/fxge/win32/cgdi_plus_ext.h
@@ -49,7 +49,6 @@
 
  private:
   HMODULE m_hModule = nullptr;
-  HMODULE m_GdiModule = nullptr;
 };
 
 #endif  // CORE_FXGE_WIN32_CGDI_PLUS_EXT_H_