commit 0d4396d2e9057d7bcb60b87053c04b41f8bc19bd
author Tom Sepez <tsepez@chromium.org> Sat Jan 11 01:00:50 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Sat Jan 11 01:00:50 2020 +0000
tree d8ba50075c5de74a9a4987f2bd0e243088e3eb17
parent f0729fffd192ca247dda242d60762cbc21656409

Remove unused const variant of CFX_GlobalData::FindGlobalVariable(),

Change-Id: I51a5bbab9f546954f77e92cb8fc31e08826334a5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/64990
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fxjs/cfx_globaldata.cpp

diff --git a/fxjs/cfx_globaldata.cpp b/fxjs/cfx_globaldata.cpp
index f5bfc82..e22be7f 100644
--- a/fxjs/cfx_globaldata.cpp
+++ b/fxjs/cfx_globaldata.cpp
@@ -122,16 +122,6 @@
   return m_arrayGlobalData.end();
 }
 
-CFX_GlobalData::const_iterator CFX_GlobalData::FindGlobalVariable(
-    const ByteString& propname) const {
-  for (auto it = m_arrayGlobalData.begin(); it != m_arrayGlobalData.end();
-       ++it) {
-    if ((*it)->data.sKey == propname)
-      return it;
-  }
-  return m_arrayGlobalData.end();
-}
-
 CFX_GlobalData::Element* CFX_GlobalData::GetGlobalVariable(
     const ByteString& propname) {
   auto iter = FindGlobalVariable(propname);

fxjs/cfx_globaldata.h

diff --git a/fxjs/cfx_globaldata.h b/fxjs/cfx_globaldata.h
index 66dc0bd..91f87af 100644
--- a/fxjs/cfx_globaldata.h
+++ b/fxjs/cfx_globaldata.h
@@ -57,7 +57,6 @@
 
  private:
   using iterator = std::vector<std::unique_ptr<Element>>::iterator;
-  using const_iterator = std::vector<std::unique_ptr<Element>>::const_iterator;
 
   explicit CFX_GlobalData(Delegate* pDelegate);
   ~CFX_GlobalData();
@@ -67,7 +66,6 @@
   bool SaveGlobalPersisitentVariables();
 
   iterator FindGlobalVariable(const ByteString& sPropname);
-  const_iterator FindGlobalVariable(const ByteString& sPropname) const;
 
   void LoadFileBuffer(const wchar_t* sFilePath,
                       uint8_t*& pBuffer,